Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 20734002: Implement correct OS and CC detection. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement correct OS and CC detection. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15923

Patch Set 1 #

Patch Set 2 : More cleanups #

Patch Set 3 : Cosmetic fixes #

Patch Set 4 : Reverted changes to atomicops*.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -191 lines) Patch
M src/compiler-intrinsics.h View 1 3 chunks +5 lines, -2 lines 0 comments Download
M src/d8.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/d8-posix.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/gdb-jit.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 9 chunks +135 lines, -45 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/isolate-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lazy-instance.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/misc-intrinsics.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/platform.h View 1 2 6 chunks +6 lines, -14 lines 0 comments Download
M src/platform-linux.cc View 1 2 6 chunks +9 lines, -24 lines 0 comments Download
M src/platform-posix.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/platform-posix.cc View 20 chunks +27 lines, -29 lines 0 comments Download
M src/platform-win32.cc View 1 2 3 9 chunks +14 lines, -16 lines 0 comments Download
M src/preparser.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/sampler.cc View 17 chunks +25 lines, -27 lines 0 comments Download
M src/snapshot-common.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/strtod.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/v8utils.h View 5 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Benedikt Meurer
First round
7 years, 4 months ago (2013-07-28 17:10:57 UTC) #1
Sven Panne
LGTM if the changes to atomicops.h are reverted: That file is a copy from Chrome's ...
7 years, 4 months ago (2013-07-29 07:54:08 UTC) #2
Benedikt Meurer
On 2013/07/29 07:54:08, Sven Panne wrote: > LGTM if the changes to atomicops.h are reverted: ...
7 years, 4 months ago (2013-07-29 07:57:48 UTC) #3
Benedikt Meurer
Reverted changes to atomicops*.h
7 years, 4 months ago (2013-07-29 09:18:58 UTC) #4
Benedikt Meurer
Committed patchset #4 manually as r15923 (presubmit successful).
7 years, 4 months ago (2013-07-29 09:19:22 UTC) #5
Sven Panne
Although this is already submitted: I think that it would be good to sync src/atomicops* ...
7 years, 4 months ago (2013-07-29 09:25:16 UTC) #6
Benedikt Meurer
7 years, 4 months ago (2013-07-29 09:26:54 UTC) #7
Message was sent while issue was closed.
On 2013/07/29 09:25:16, Sven Panne wrote:
> Although this is already submitted: I think that it would be good to sync
> src/atomicops* with chromium/src/base/ again, keeping the diff at a minimum.
> Jochen/Danno: WDYT?

Chromium has a different set of #define's here. But as long as everything else
is untouched, we can just copy over the chromium files and fixup the #ifdef's.

Powered by Google App Engine
This is Rietveld 408576698