Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Side by Side Diff: src/strtod.cc

Issue 20734002: Implement correct OS and CC detection. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reverted changes to atomicops*.h Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/snapshot-common.cc ('k') | src/v8utils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 int exponent = 0; 169 int exponent = 0;
170 *result = DiyFp(significand, exponent); 170 *result = DiyFp(significand, exponent);
171 *remaining_decimals = buffer.length() - read_digits; 171 *remaining_decimals = buffer.length() - read_digits;
172 } 172 }
173 } 173 }
174 174
175 175
176 static bool DoubleStrtod(Vector<const char> trimmed, 176 static bool DoubleStrtod(Vector<const char> trimmed,
177 int exponent, 177 int exponent,
178 double* result) { 178 double* result) {
179 #if (V8_TARGET_ARCH_IA32 || defined(USE_SIMULATOR)) && !defined(_MSC_VER) 179 #if (V8_TARGET_ARCH_IA32 || defined(USE_SIMULATOR)) && !V8_CC_MSVC
180 // On x86 the floating-point stack can be 64 or 80 bits wide. If it is 180 // On x86 the floating-point stack can be 64 or 80 bits wide. If it is
181 // 80 bits wide (as is the case on Linux) then double-rounding occurs and the 181 // 80 bits wide (as is the case on Linux) then double-rounding occurs and the
182 // result is not accurate. 182 // result is not accurate.
183 // We know that Windows32 with MSVC, unlike with MinGW32, uses 64 bits and is 183 // We know that Windows32 with MSVC, unlike with MinGW32, uses 64 bits and is
184 // therefore accurate. 184 // therefore accurate.
185 // Note that the ARM and MIPS simulators are compiled for 32bits. They 185 // Note that the ARM and MIPS simulators are compiled for 32bits. They
186 // therefore exhibit the same problem. 186 // therefore exhibit the same problem.
187 return false; 187 return false;
188 #endif 188 #endif
189 if (trimmed.length() <= kMaxExactDoubleIntegerDecimalDigits) { 189 if (trimmed.length() <= kMaxExactDoubleIntegerDecimalDigits) {
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 433
434 double guess; 434 double guess;
435 if (DoubleStrtod(trimmed, exponent, &guess) || 435 if (DoubleStrtod(trimmed, exponent, &guess) ||
436 DiyFpStrtod(trimmed, exponent, &guess)) { 436 DiyFpStrtod(trimmed, exponent, &guess)) {
437 return guess; 437 return guess;
438 } 438 }
439 return BignumStrtod(trimmed, exponent, guess); 439 return BignumStrtod(trimmed, exponent, guess);
440 } 440 }
441 441
442 } } // namespace v8::internal 442 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/snapshot-common.cc ('k') | src/v8utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698