Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: src/lazy-instance.h

Issue 20734002: Implement correct OS and CC detection. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reverted changes to atomicops*.h Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate-inl.h ('k') | src/misc-intrinsics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lazy-instance.h
diff --git a/src/lazy-instance.h b/src/lazy-instance.h
index 9d68b8cacce0f0f4815f6a5940716df0ddf83bbb..048b0b1205ff0ba05397c23e3479350648011788 100644
--- a/src/lazy-instance.h
+++ b/src/lazy-instance.h
@@ -111,9 +111,9 @@ struct LeakyInstanceTrait {
// Traits that define how an instance is allocated and accessed.
-// TODO(kalmard): __alignof__ is only defined for GCC > 4.2. Fix alignment issue
-// on MIPS with other compilers.
-#if defined(__GNUC__) && (__GNUC__ > 4 || (__GNUC__ == 4 && __GNUC_MINOR__ > 2))
+// TODO(kalmard): __alignof__ is only defined for GCC >= 4.3.
+// Fix alignment issue on MIPS with other compilers.
+#if V8_GNUC_PREREQ(4, 3)
#define LAZY_ALIGN(x) __attribute__((aligned(__alignof__(x))))
#else
#define LAZY_ALIGN(x)
« no previous file with comments | « src/isolate-inl.h ('k') | src/misc-intrinsics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698