Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2073283002: GN: Consolidate some printing test exclusion rules. (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Consolidate some printing test exclusion rules. BUG=617477 Committed: https://crrev.com/788d0f8e2a4e19db99b1336aff379f60c3f0063d Cr-Commit-Position: refs/heads/master@{#400539}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Logic is hard #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M chrome/test/BUILD.gn View 1 4 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Lei Zhang
4 years, 6 months ago (2016-06-17 21:12:05 UTC) #2
Robert Sesek
https://codereview.chromium.org/2073283002/diff/1/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/2073283002/diff/1/chrome/test/BUILD.gn#newcode1436 chrome/test/BUILD.gn:1436: "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc", I think this has to be excluded even ...
4 years, 6 months ago (2016-06-17 21:46:55 UTC) #3
Lei Zhang
https://codereview.chromium.org/2073283002/diff/1/chrome/test/BUILD.gn File chrome/test/BUILD.gn (right): https://codereview.chromium.org/2073283002/diff/1/chrome/test/BUILD.gn#newcode1436 chrome/test/BUILD.gn:1436: "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc", On 2016/06/17 21:46:55, Robert Sesek wrote: > I ...
4 years, 6 months ago (2016-06-17 21:57:56 UTC) #4
Robert Sesek
LGTM
4 years, 6 months ago (2016-06-17 22:17:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2073283002/20001
4 years, 6 months ago (2016-06-17 22:19:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-17 23:25:54 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 23:27:19 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/788d0f8e2a4e19db99b1336aff379f60c3f0063d
Cr-Commit-Position: refs/heads/master@{#400539}

Powered by Google App Engine
This is Rietveld 408576698