GN: Consolidate some printing test exclusion rules.

chrome/test/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//chrome/chrome_tests.gni")
@@ skipping 1137 matching lines @@
     }
 
     if (is_chromeos) {
       sources += rebase_path(
               chrome_tests_gypi_values.chrome_browser_tests_chromeos_sources,
               ".",
               "//chrome")
       sources -= [
         "../../apps/load_and_launch_browsertest.cc",
         "../browser/policy/policy_startup_browsertest.cc",
-        "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc",
-        "../browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc",
 
         # chromeos does not support profile list avatar menu
         "../browser/profiles/profile_list_desktop_browsertest.cc",
         "../browser/service_process/service_process_control_browsertest.cc",
 
         # chromeos does not use cross-platform panels
         "../browser/ui/panels/panel_extension_browsertest.cc",
 
         # inline login UI is disabled on chromeos
         "../browser/ui/webui/signin/inline_login_ui_browsertest.cc",
@@ skipping 133 matching lines @@
         "../browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper_browsertest.mm",
         "../browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc",
       ]
       sources -= [
         # TODO(groby): This test depends on hunspell and we cannot run it on
         # Mac, which does not use hunspell by default.
         "../browser/spellchecker/spellcheck_service_browsertest.cc",
 
         # ProcessSingletonMac doesn"t do anything.
         "../browser/process_singleton_browsertest.cc",
-
-        # This test depends on GetCommandLineForRelaunch, which is not
-        # available on Mac.
-        "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc",
       ]
 
       if (safe_browsing_mode == 1) {
         sources -= [
           # single-process mode hangs on Mac sometimes because of multiple UI
           # message loops. See 306348
           "../renderer/safe_browsing/phishing_classifier_browsertest.cc",
           "../renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc",
         ]
       }
@@ skipping 94 matching lines @@
     if (enable_pepper_cdms) {
       # Runtime dependencies.
       data_deps += [
         "//media/cdm/ppapi:clearkeycdmadapter",
         "//third_party/widevine/cdm:widevinecdmadapter",
       ]
     }
     if (!enable_print_preview) {
       sources -= [
         "../browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc",
-        "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc",
-        "../browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc",
         "../browser/printing/print_preview_dialog_controller_browsertest.cc",
         "../browser/printing/print_preview_pdf_generated_browsertest.cc",
         "../browser/service_process/service_process_control_browsertest.cc",
         "../browser/ui/webui/print_preview/print_preview_ui_browsertest.cc",
         "data/webui/print_preview.cc",
         "data/webui/print_preview.h",
       ]
+      if (is_mac || is_chromeos) {
+        sources -= [
+          # This test depends on GetCommandLineForRelaunch, which is not
+          # available on Mac. It is also not intended to run on ChromeOS.
+          "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc",

[Robert Sesek, 2016/06/17 21:46:55]

I think this has to be excluded even if enable_print_preview=true.

[Lei Zhang, 2016/06/17 21:57:56]

Right.

+        ]
+      }
+      if (is_chromeos) {
+        sources -= [
+          # Not intended to run on ChromeOS.
+          "../browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc",
+        ]
+      }
     }
     if (enable_mdns) {
       sources += [
         "../browser/extensions/api/gcd_private/gcd_private_apitest.cc",
         "../browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc",
       ]
     }
     if (use_brlapi) {
       deps += [ "//build/linux/libbrlapi" ]
     } else {
@@ skipping 1012 matching lines @@
 if (is_android) {
   android_library("unit_tests_java") {
     java_files = [ "android/unit_tests_apk/src/org/chromium/chrome/unit_tests_apk/ChromeNativeTestApplication.java" ]
     deps = [
       "//base:base_java",
       "//chrome/android:chrome_java",
       "//content/public/android:content_java",
     ]
   }
 }