Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8819)

Unified Diff: chrome/test/BUILD.gn

Issue 2073283002: GN: Consolidate some printing test exclusion rules. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Logic is hard Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index e0f20cfafdfc1cb440cdd793036a36745f8f20cc..83029d6dbc524b2d3f819f1602f0a61fe78e72eb 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -1155,8 +1155,6 @@ if (!is_android) {
sources -= [
"../../apps/load_and_launch_browsertest.cc",
"../browser/policy/policy_startup_browsertest.cc",
- "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc",
- "../browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc",
# chromeos does not support profile list avatar menu
"../browser/profiles/profile_list_desktop_browsertest.cc",
@@ -1310,10 +1308,6 @@ if (!is_android) {
# ProcessSingletonMac doesn"t do anything.
"../browser/process_singleton_browsertest.cc",
-
- # This test depends on GetCommandLineForRelaunch, which is not
- # available on Mac.
- "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc",
]
if (safe_browsing_mode == 1) {
@@ -1428,8 +1422,6 @@ if (!is_android) {
if (!enable_print_preview) {
sources -= [
"../browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc",
- "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc",
- "../browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc",
"../browser/printing/print_preview_dialog_controller_browsertest.cc",
"../browser/printing/print_preview_pdf_generated_browsertest.cc",
"../browser/service_process/service_process_control_browsertest.cc",
@@ -1438,6 +1430,19 @@ if (!is_android) {
"data/webui/print_preview.h",
]
}
+ if (!enable_print_preview || is_mac || is_chromeos) {
+ sources -= [
+ # This test depends on GetCommandLineForRelaunch, which is not
+ # available on Mac. It is also not intended to run on ChromeOS.
+ "../browser/printing/cloud_print/test/cloud_print_policy_browsertest.cc",
+ ]
+ }
+ if (!enable_print_preview || is_chromeos) {
+ sources -= [
+ # Not intended to run on ChromeOS.
+ "../browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc",
+ ]
+ }
if (enable_mdns) {
sources += [
"../browser/extensions/api/gcd_private/gcd_private_apitest.cc",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698