[Password Generation] Sends CSS classes inside autofill proto

[Password Generation] Sends CSS classes to autofill server inside autofill proto

CSS classes might contain info that is useful for form classifier to detect the forms where password generation should be available.

BUG=582434
Committed: https://crrev.com/c716a5cce97964dbac7592454df284f4840708f5
Cr-Commit-Position: refs/heads/master@{#400968}

[kolos1, 2016-06-17 11:28:46]

Description was changed from

==========
[Password Generation] Sends CSS classes inside autofill proto

BUG=582434
==========

to

==========
[Password Generation] Sends CSS classes to autofill server inside autofill proto

BUG=582434
==========

[kolos1, 2016-06-17 11:29:33]

Description was changed from

==========
[Password Generation] Sends CSS classes to autofill server inside autofill proto

BUG=582434
==========

to

==========
[Password Generation] Sends CSS classes to autofill server inside autofill proto

CSS classes might contain info that is useful for form classifier to detect the
forms where password generation should be available.

BUG=582434
==========

[kolos1, 2016-06-17 12:07:43]

Patchset #1 (id:1) has been deleted

[kolos1, 2016-06-17 12:07:51]

Patchset #1 (id:20001) has been deleted

[kolos1, 2016-06-17 12:07:58]

Patchset #1 (id:40001) has been deleted

[kolos1, 2016-06-17 12:08:04]

Patchset #1 (id:60001) has been deleted

[kolos1, 2016-06-17 12:08:15]

Patchset #1 (id:80001) has been deleted

[kolos1, 2016-06-17 12:09:02]

kolos@chromium.org changed reviewers:
+ vabr@chromium.org

[kolos1, 2016-06-17 12:09:03]

Hi Vaclav,

Please review this CL.

Best regards,
Maxim

[vabr (Chromium), 2016-06-17 13:14:42]

Thanks, Maxim.

This LGTM, I just have one question about a test below.

Cheers,
Vaclav

https://codereview.chromium.org/2073093002/diff/100001/components/autofill/co...
File components/autofill/core/browser/form_structure_unittest.cc (right):

https://codereview.chromium.org/2073093002/diff/100001/components/autofill/co...
components/autofill/core/browser/form_structure_unittest.cc:2468:
form_structure.reset(new FormStructure(form));
How do the lines 2468 and 2469 influence the rest of the test?
It seems like |form_structure| is not touched again until 2488, when it is
re-created.

[vabr (Chromium), 2016-06-17 13:14:43]

Thanks, Maxim.

This LGTM, I just have one question about a test below.

Cheers,
Vaclav

[kolos1, 2016-06-20 11:51:50]

Replied to your question and also changed
FormStructureTest.EncodeUploadRequest_DisabledMetadataTrial (the class attribute
shouldn't be uploaded if AutofillFieldMetadat is disabled)

Please review.

Regards,
Maxim

https://codereview.chromium.org/2073093002/diff/100001/components/autofill/co...
File components/autofill/core/browser/form_structure_unittest.cc (right):

https://codereview.chromium.org/2073093002/diff/100001/components/autofill/co...
components/autofill/core/browser/form_structure_unittest.cc:2468:
form_structure.reset(new FormStructure(form));
On 2016/06/17 13:14:42, vabr (Chromium) wrote:
> How do the lines 2468 and 2469 influence the rest of the test?
> It seems like |form_structure| is not touched again until 2488, when it is
> re-created.

Oh, good point. I copied it from other EncodeUploadRequest_.* tests. As I
understand, there are no any side effects in DetermineHeuristicTypes(). So, the
first initialization is useless. Removed it. Thanks.

[vabr (Chromium), 2016-06-20 12:15:51]

LGTM, thanks!
Vaclav

[kolos1, 2016-06-21 12:37:08]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2016-06-21 12:37:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2073093002/120001

[commit-bot: I haz the power, 2016-06-21 12:41:01]

Description was changed from

==========
[Password Generation] Sends CSS classes to autofill server inside autofill proto

CSS classes might contain info that is useful for form classifier to detect the
forms where password generation should be available.

BUG=582434
==========

to

==========
[Password Generation] Sends CSS classes to autofill server inside autofill proto

CSS classes might contain info that is useful for form classifier to detect the
forms where password generation should be available.

BUG=582434
==========

[commit-bot: I haz the power, 2016-06-21 12:41:02]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-06-21 12:44:08]

Description was changed from

==========
[Password Generation] Sends CSS classes to autofill server inside autofill proto

CSS classes might contain info that is useful for form classifier to detect the
forms where password generation should be available.

BUG=582434
==========

to

==========
[Password Generation] Sends CSS classes to autofill server inside autofill proto

CSS classes might contain info that is useful for form classifier to detect the
forms where password generation should be available.

BUG=582434

Committed: https://crrev.com/c716a5cce97964dbac7592454df284f4840708f5
Cr-Commit-Position: refs/heads/master@{#400968}
==========

[commit-bot: I haz the power, 2016-06-21 12:44:09]

Patchset 2 (id:??) landed as
https://crrev.com/c716a5cce97964dbac7592454df284f4840708f5
Cr-Commit-Position: refs/heads/master@{#400968}

[gebreel2014.ga, 2016-07-20 11:30:23]

gebreel2014.ga@gmail.com changed reviewers:
+ gebreel2014.ga@gmail.com