components/autofill/core/browser/form_structure.cc - Issue 2073093002: [Password Generation] Sends CSS classes inside autofill proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/form_structure.cc

Issue 2073093002: [Password Generation] Sends CSS classes inside autofill proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed useless FormStructure recreation in FormStructureTest.EncodeUploadRequest_WithCssClasses Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_test_utils.cc ('k') | components/autofill/core/browser/form_structure_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/form_structure.cc

diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc

index b62f9747c86340ce8cd73ca9702d0d3d88c80446..61bcd71a5ce86a6c760703fdb58dc3cbbdf2ed5c 100644

--- a/components/autofill/core/browser/form_structure.cc

+++ b/components/autofill/core/browser/form_structure.cc

@@ -1181,6 +1181,9 @@ void FormStructure::EncodeFormForUpload(AutofillUploadContents* upload) const {

if (!field->autocomplete_attribute.empty())

added_field->set_autocomplete(field->autocomplete_attribute);

+ if (!field->css_classes.empty())

+ added_field->set_css_classes(base::UTF16ToUTF8(field->css_classes));

}