src/mips/macro-assembler-mips.cc - Issue 2072963003: Simplify AssemblerPositionsRecorder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/macro-assembler-mips.cc

Issue 2072963003: Simplify AssemblerPositionsRecorder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/macro-assembler-mips.cc

diff --git a/src/mips/macro-assembler-mips.cc b/src/mips/macro-assembler-mips.cc

index a58084cfbef4f76a98e8ce55691b7ba81ba77175..bfc78f93fea6dda0ba42d0ac4e20385471fd881a 100644

--- a/src/mips/macro-assembler-mips.cc

+++ b/src/mips/macro-assembler-mips.cc

@@ -3832,9 +3832,6 @@ void MacroAssembler::Call(Address target,

Label start;

bind(&start);

int32_t target_int = reinterpret_cast<int32_t>(target);

- // Must record previous source positions before the

- // li() generates a new code target.

- positions_recorder()->WriteRecordedPositions();

li(t9, Operand(target_int, rmode), CONSTANT_SIZE);

Call(t9, cond, rs, rt, bd);

DCHECK_EQ(CallSize(target, rmode, cond, rs, rt, bd),