Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2072963002: Remove PaymentResponse.totalAmount according to latest spec (Closed)

Created:
4 years, 6 months ago by kbalazs
Modified:
4 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, haraken, dglazkov+blink, blink-reviews, darin (slow to review), ben+mojo_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PaymentResponse.totalAmount according to latest spec https://github.com/w3c/browser-payment-api/pull/219/commits/f06528fdc71db20867016f29419f2150536a86b5 BUG=620901 Committed: https://crrev.com/4486435b203881b6163a25f93b9c92812c83478a Cr-Commit-Position: refs/heads/master@{#400821}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove PaymentResponse.totalAmount according to latest spec #

Total comments: 2

Patch Set 3 : nits and layout test results #

Patch Set 4 : rebased #

Patch Set 5 : rebase #

Patch Set 6 : final touch-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -46 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/android/payments/dynamic_shipping.js View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/android/payments/free_shipping.js View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/android/payments/no_shipping.js View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/payments/promises-keep-request-alive.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp View 1 2 3 4 10 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.h View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.cpp View 1 2 3 4 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponse.idl View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp View 1 2 3 4 5 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/payments/payment_request.mojom View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (8 generated)
kbalazs
4 years, 6 months ago (2016-06-16 23:40:02 UTC) #2
kbalazs
4 years, 6 months ago (2016-06-16 23:42:32 UTC) #3
please use gerrit instead
https://codereview.chromium.org/2072963002/diff/1/chrome/test/data/android/payments/no_shipping.js File chrome/test/data/android/payments/no_shipping.js (left): https://codereview.chromium.org/2072963002/diff/1/chrome/test/data/android/payments/no_shipping.js#oldcode22 chrome/test/data/android/payments/no_shipping.js:22: JSON.stringify(resp.totalAmount, undefined, 2) + '<br>' + Also update https://cs.chromium.org/chromium/src/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestNoShippingTest.java?rcl=0&l=78 ...
4 years, 6 months ago (2016-06-16 23:47:15 UTC) #4
kbalazs
@palmer: public/ @bauerb: chrome/android
4 years, 6 months ago (2016-06-16 23:47:58 UTC) #6
kbalazs
https://codereview.chromium.org/2072963002/diff/1/chrome/test/data/android/payments/no_shipping.js File chrome/test/data/android/payments/no_shipping.js (left): https://codereview.chromium.org/2072963002/diff/1/chrome/test/data/android/payments/no_shipping.js#oldcode22 chrome/test/data/android/payments/no_shipping.js:22: JSON.stringify(resp.totalAmount, undefined, 2) + '<br>' + On 2016/06/16 23:47:15, ...
4 years, 6 months ago (2016-06-16 23:56:13 UTC) #7
palmer
lgtm
4 years, 6 months ago (2016-06-17 00:01:40 UTC) #8
please use gerrit instead
https://codereview.chromium.org/2072963002/diff/1/chrome/test/data/android/payments/no_shipping.js File chrome/test/data/android/payments/no_shipping.js (left): https://codereview.chromium.org/2072963002/diff/1/chrome/test/data/android/payments/no_shipping.js#oldcode22 chrome/test/data/android/payments/no_shipping.js:22: JSON.stringify(resp.totalAmount, undefined, 2) + '<br>' + On 2016/06/16 23:56:13, ...
4 years, 6 months ago (2016-06-17 00:04:50 UTC) #9
Bernhard Bauer
Android LGTM.
4 years, 6 months ago (2016-06-17 14:08:27 UTC) #10
please use gerrit instead
Minor nits. https://codereview.chromium.org/2072963002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java (right): https://codereview.chromium.org/2072963002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java#newcode46 chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestFreeShippingTest.java:46: "freeShippingOption" }); No space between " and ...
4 years, 6 months ago (2016-06-17 16:03:36 UTC) #11
kbalazs
Seems like all green now, PTAL.
4 years, 6 months ago (2016-06-20 17:27:11 UTC) #12
please use gerrit instead
LGTM, but you need to rebase before landing. PaymentRequestTest.*InResponse tests have been moved into OnPaymentResponseTest.cpp.
4 years, 6 months ago (2016-06-20 17:30:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072963002/70001
4 years, 6 months ago (2016-06-20 19:50:07 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/83905)
4 years, 6 months ago (2016-06-20 20:04:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072963002/90001
4 years, 6 months ago (2016-06-20 21:06:36 UTC) #21
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 6 months ago (2016-06-20 22:59:53 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 23:01:06 UTC) #24
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/4486435b203881b6163a25f93b9c92812c83478a
Cr-Commit-Position: refs/heads/master@{#400821}

Powered by Google App Engine
This is Rietveld 408576698