third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp - Issue 2072963002: Remove PaymentResponse.totalAmount according to latest spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp

Issue 2072963002: Remove PaymentResponse.totalAmount according to latest spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: final touch-up Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentResponse.idl ('k') | third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp

index 577877f79d521192779a3ad53b1733a40ae91b36..35da551475c3540bd99e0d0fd453386bf6539029 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp

@@ -45,8 +45,6 @@ TEST(PaymentResponseTest, DataCopiedOver)

V8TestingScope scope;

mojom::blink::PaymentResponsePtr input = buildPaymentResponseForTest();

input->method_name = "foo";

- input->total_amount->currency = "USD";

- input->total_amount->value = "5.00";

input->stringified_details = "{\"transactionId\": 123}";

input->shipping_option = "standardShippingOption";

input->payer_email = "abc@gmail.com";

@@ -60,11 +58,6 @@ TEST(PaymentResponseTest, DataCopiedOver)

EXPECT_EQ("abc@gmail.com", output.payerEmail());

EXPECT_EQ("0123", output.payerPhone());

- PaymentCurrencyAmount totalAmount;

- output.totalAmount(totalAmount);

- EXPECT_EQ("USD", totalAmount.currency());

- EXPECT_EQ("5.00", totalAmount.value());

ScriptValue details = output.details(scope.getScriptState(), scope.getExceptionState());

ASSERT_FALSE(scope.getExceptionState().hadException());