third_party/WebKit/Source/modules/payments/PaymentResponse.h - Issue 2072963002: Remove PaymentResponse.totalAmount according to latest spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.h

Issue 2072963002: Remove PaymentResponse.totalAmount according to latest spec (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: final touch-up Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/payments/OnPaymentResponseTest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentResponse.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentResponse.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.h b/third_party/WebKit/Source/modules/payments/PaymentResponse.h

index f41d5fa027898a838a83e21246cfd0a3d3ff5161..1f9594ce4a9741d2053b13bee6455ac51d345b42 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.h

@@ -31,7 +31,6 @@ public:

virtual ~PaymentResponse();

const String& methodName() const { return m_methodName; }

- void totalAmount(PaymentCurrencyAmount& result) const { result = m_totalAmount; }

ScriptValue details(ScriptState*, ExceptionState&) const;

PaymentAddress* shippingAddress() const { return m_shippingAddress.get(); }

const String& shippingOption() const { return m_shippingOption; }

@@ -44,7 +43,6 @@ public:

private:

String m_methodName;

- PaymentCurrencyAmount m_totalAmount;

String m_stringifiedDetails;

Member<PaymentAddress> m_shippingAddress;

String m_shippingOption;