Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2072813003: [test] Move CodeAssembler tests to a separate file. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Move CodeAssembler tests to a separate file. Committed: https://crrev.com/b98e3949a3d472724f5fd8bfcd7bf70c37c84289 Cr-Commit-Position: refs/heads/master@{#37069}

Patch Set 1 #

Patch Set 2 : Fix windows builds #

Patch Set 3 : Minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -358 lines) Patch
M src/compiler/code-assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A test/cctest/compiler/code-assembler-tester.h View 1 1 chunk +67 lines, -0 lines 0 comments Download
A test/cctest/compiler/test-code-assembler.cc View 1 chunk +353 lines, -0 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 1 2 18 chunks +37 lines, -356 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 31 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072813003/1
4 years, 6 months ago (2016-06-17 09:09:51 UTC) #3
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-17 09:09:55 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/19163) v8_win_nosnap_shared_rel_ng on ...
4 years, 6 months ago (2016-06-17 09:19:41 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072813003/20001
4 years, 6 months ago (2016-06-17 09:37:44 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 10:05:09 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072813003/40001
4 years, 6 months ago (2016-06-17 10:09:44 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/3361) v8_linux_arm64_rel_ng on ...
4 years, 6 months ago (2016-06-17 10:11:58 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072813003/60001
4 years, 6 months ago (2016-06-17 10:15:35 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/3362) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 6 months ago (2016-06-17 10:30:03 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072813003/80001
4 years, 6 months ago (2016-06-17 11:22:39 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 11:50:32 UTC) #25
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-17 13:18:16 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072813003/80001
4 years, 6 months ago (2016-06-17 13:18:22 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 6 months ago (2016-06-17 13:20:14 UTC) #29
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 13:23:22 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b98e3949a3d472724f5fd8bfcd7bf70c37c84289
Cr-Commit-Position: refs/heads/master@{#37069}

Powered by Google App Engine
This is Rietveld 408576698