[test] Move CodeAssembler tests to a separate file.

test/cctest/test-code-stub-assembler.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/base/utils/random-number-generator.h"
 #include "src/ic/stub-cache.h"
-#include "src/interface-descriptors.h"
 #include "src/isolate.h"
+#include "test/cctest/compiler/code-assembler-tester.h"
 #include "test/cctest/compiler/function-tester.h"
 
 namespace v8 {
 namespace internal {
 
 using compiler::FunctionTester;
 using compiler::Node;
 
-class ZoneHolder {
- public:
-  explicit ZoneHolder(Isolate* isolate) : zone_(isolate->allocator()) {}
-  Zone* zone() { return &zone_; }
-
- private:
-  Zone zone_;
-};
-
-// Inherit from ZoneHolder in order to create a zone that can be passed to
-// CodeStubAssembler base class constructor.
-class CodeStubAssemblerTester : private ZoneHolder, public CodeStubAssembler {
- public:
-  // Test generating code for a stub.
-  CodeStubAssemblerTester(Isolate* isolate,
-                          const CallInterfaceDescriptor& descriptor)
-      : ZoneHolder(isolate),
-        CodeStubAssembler(isolate, ZoneHolder::zone(), descriptor,
-                          Code::ComputeFlags(Code::STUB), "test"),
-        scope_(isolate) {}
-
-  // Test generating code for a JS function (e.g. builtins).
-  CodeStubAssemblerTester(Isolate* isolate, int parameter_count)
-      : ZoneHolder(isolate),
-        CodeStubAssembler(isolate, ZoneHolder::zone(), parameter_count,
-                          Code::ComputeFlags(Code::FUNCTION), "test"),
-        scope_(isolate) {}
-
-  // This constructor is intended to be used for creating code objects with
-  // specific flags.
-  CodeStubAssemblerTester(Isolate* isolate, Code::Flags flags)
-      : ZoneHolder(isolate),
-        CodeStubAssembler(isolate, ZoneHolder::zone(), 0, flags, "test"),
-        scope_(isolate) {}
-
-  Handle<Code> GenerateCodeCloseAndEscape() {
-    return scope_.CloseAndEscape(GenerateCode());
-  }
-
- private:
-  HandleScope scope_;
-  LocalContext context_;
-};
-
-TEST(SimpleSmiReturn) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  m.Return(m.SmiTag(m.Int32Constant(37)));
-  Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(descriptor, code);
-  MaybeHandle<Object> result = ft.Call();
-  CHECK_EQ(37, Handle<Smi>::cast(result.ToHandleChecked())->value());
-}
-
-TEST(SimpleIntPtrReturn) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  int test;
-  m.Return(m.IntPtrConstant(reinterpret_cast<intptr_t>(&test)));
-  Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(descriptor, code);
-  MaybeHandle<Object> result = ft.Call();
-  CHECK_EQ(reinterpret_cast<intptr_t>(&test),
-           reinterpret_cast<intptr_t>(*result.ToHandleChecked()));
-}
-
-TEST(SimpleDoubleReturn) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  m.Return(m.NumberConstant(0.5));
-  Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(descriptor, code);
-  MaybeHandle<Object> result = ft.Call();
-  CHECK_EQ(0.5, Handle<HeapNumber>::cast(result.ToHandleChecked())->value());
-}
-
-TEST(SimpleCallRuntime1Arg) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  Node* context = m.HeapConstant(Handle<Context>(isolate->native_context()));
-  Node* b = m.SmiTag(m.Int32Constant(0));
-  m.Return(m.CallRuntime(Runtime::kNumberToSmi, context, b));
-  Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(descriptor, code);
-  MaybeHandle<Object> result = ft.Call();
-  CHECK_EQ(0, Handle<Smi>::cast(result.ToHandleChecked())->value());
-}
-
-TEST(SimpleTailCallRuntime1Arg) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  Node* context = m.HeapConstant(Handle<Context>(isolate->native_context()));
-  Node* b = m.SmiTag(m.Int32Constant(0));
-  m.TailCallRuntime(Runtime::kNumberToSmi, context, b);
-  Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(descriptor, code);
-  MaybeHandle<Object> result = ft.Call();
-  CHECK_EQ(0, Handle<Smi>::cast(result.ToHandleChecked())->value());
-}
-
-TEST(SimpleCallRuntime2Arg) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  Node* context = m.HeapConstant(Handle<Context>(isolate->native_context()));
-  Node* a = m.SmiTag(m.Int32Constant(2));
-  Node* b = m.SmiTag(m.Int32Constant(4));
-  m.Return(m.CallRuntime(Runtime::kMathPow, context, a, b));
-  Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(descriptor, code);
-  MaybeHandle<Object> result = ft.Call();
-  CHECK_EQ(16, Handle<Smi>::cast(result.ToHandleChecked())->value());
-}
-
-TEST(SimpleTailCallRuntime2Arg) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  Node* context = m.HeapConstant(Handle<Context>(isolate->native_context()));
-  Node* a = m.SmiTag(m.Int32Constant(2));
-  Node* b = m.SmiTag(m.Int32Constant(4));
-  m.TailCallRuntime(Runtime::kMathPow, context, a, b);
-  Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(descriptor, code);
-  MaybeHandle<Object> result = ft.Call();
-  CHECK_EQ(16, Handle<Smi>::cast(result.ToHandleChecked())->value());
-}
-
-TEST(VariableMerge1) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  CodeStubAssembler::Variable var1(&m, MachineRepresentation::kTagged);
-  CodeStubAssembler::Label l1(&m), l2(&m), merge(&m);
-  Node* temp = m.Int32Constant(0);
-  var1.Bind(temp);
-  m.Branch(m.Int32Constant(1), &l1, &l2);
-  m.Bind(&l1);
-  CHECK_EQ(var1.value(), temp);
-  m.Goto(&merge);
-  m.Bind(&l2);
-  CHECK_EQ(var1.value(), temp);
-  m.Goto(&merge);
-  m.Bind(&merge);
-  CHECK_EQ(var1.value(), temp);
-}
-
-TEST(VariableMerge2) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  CodeStubAssembler::Variable var1(&m, MachineRepresentation::kTagged);
-  CodeStubAssembler::Label l1(&m), l2(&m), merge(&m);
-  Node* temp = m.Int32Constant(0);
-  var1.Bind(temp);
-  m.Branch(m.Int32Constant(1), &l1, &l2);
-  m.Bind(&l1);
-  CHECK_EQ(var1.value(), temp);
-  m.Goto(&merge);
-  m.Bind(&l2);
-  Node* temp2 = m.Int32Constant(2);
-  var1.Bind(temp2);
-  CHECK_EQ(var1.value(), temp2);
-  m.Goto(&merge);
-  m.Bind(&merge);
-  CHECK_NE(var1.value(), temp);
-}
-
-TEST(VariableMerge3) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  CodeStubAssembler::Variable var1(&m, MachineRepresentation::kTagged);
-  CodeStubAssembler::Variable var2(&m, MachineRepresentation::kTagged);
-  CodeStubAssembler::Label l1(&m), l2(&m), merge(&m);
-  Node* temp = m.Int32Constant(0);
-  var1.Bind(temp);
-  var2.Bind(temp);
-  m.Branch(m.Int32Constant(1), &l1, &l2);
-  m.Bind(&l1);
-  CHECK_EQ(var1.value(), temp);
-  m.Goto(&merge);
-  m.Bind(&l2);
-  Node* temp2 = m.Int32Constant(2);
-  var1.Bind(temp2);
-  CHECK_EQ(var1.value(), temp2);
-  m.Goto(&merge);
-  m.Bind(&merge);
-  CHECK_NE(var1.value(), temp);
-  CHECK_NE(var1.value(), temp2);
-  CHECK_EQ(var2.value(), temp);
-}
-
-TEST(VariableMergeBindFirst) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  CodeStubAssembler::Variable var1(&m, MachineRepresentation::kTagged);
-  CodeStubAssembler::Label l1(&m), l2(&m), merge(&m, &var1), end(&m);
-  Node* temp = m.Int32Constant(0);
-  var1.Bind(temp);
-  m.Branch(m.Int32Constant(1), &l1, &l2);
-  m.Bind(&l1);
-  CHECK_EQ(var1.value(), temp);
-  m.Goto(&merge);
-  m.Bind(&merge);
-  CHECK(var1.value() != temp);
-  CHECK(var1.value() != nullptr);
-  m.Goto(&end);
-  m.Bind(&l2);
-  Node* temp2 = m.Int32Constant(2);
-  var1.Bind(temp2);
-  CHECK_EQ(var1.value(), temp2);
-  m.Goto(&merge);
-  m.Bind(&end);
-  CHECK(var1.value() != temp);
-  CHECK(var1.value() != nullptr);
-}
-
-TEST(VariableMergeSwitch) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  CodeStubAssembler::Variable var1(&m, MachineRepresentation::kTagged);
-  CodeStubAssembler::Label l1(&m), l2(&m), default_label(&m);
-  CodeStubAssembler::Label* labels[] = {&l1, &l2};
-  int32_t values[] = {1, 2};
-  Node* temp = m.Int32Constant(0);
-  var1.Bind(temp);
-  m.Switch(m.Int32Constant(2), &default_label, values, labels, 2);
-  m.Bind(&l1);
-  DCHECK_EQ(temp, var1.value());
-  m.Return(temp);
-  m.Bind(&l2);
-  DCHECK_EQ(temp, var1.value());
-  m.Return(temp);
-  m.Bind(&default_label);
-  DCHECK_EQ(temp, var1.value());
-  m.Return(temp);
-}
+typedef compiler::CodeAssemblerTesterImpl<CodeStubAssembler>
+    CodeStubAssemblerTester;
 
 TEST(FixedArrayAccessSmiIndex) {
   Isolate* isolate(CcTest::InitIsolateOnce());
   VoidDescriptor descriptor(isolate);
   CodeStubAssemblerTester m(isolate, descriptor);
   Handle<FixedArray> array = isolate->factory()->NewFixedArray(5);
   array->set(4, Smi::FromInt(733));
   m.Return(m.LoadFixedArrayElement(m.HeapConstant(array),
                                    m.SmiTag(m.Int32Constant(4)), 0,
                                    CodeStubAssembler::SMI_PARAMETERS));
@@ skipping 22 matching lines @@
   CodeStubAssemblerTester m(isolate, descriptor);
   Handle<HeapObject> undefined = isolate->factory()->undefined_value();
   m.Return(m.SmiTag(m.LoadInstanceType(m.HeapConstant(undefined))));
   Handle<Code> code = m.GenerateCode();
   FunctionTester ft(descriptor, code);
   MaybeHandle<Object> result = ft.Call();
   CHECK_EQ(InstanceType::ODDBALL_TYPE,
            Handle<Smi>::cast(result.ToHandleChecked())->value());
 }
 
-namespace {
-
-class TestBitField : public BitField<unsigned, 3, 3> {};
-
-}  // namespace
-
 TEST(BitFieldDecode) {
   Isolate* isolate(CcTest::InitIsolateOnce());
   VoidDescriptor descriptor(isolate);
   CodeStubAssemblerTester m(isolate, descriptor);
+
+  class TestBitField : public BitField<unsigned, 3, 3> {};
   m.Return(m.SmiTag(m.BitFieldDecode<TestBitField>(m.Int32Constant(0x2f))));
   Handle<Code> code = m.GenerateCode();
   FunctionTester ft(descriptor, code);
   MaybeHandle<Object> result = ft.Call();
   // value  = 00101111
   // mask   = 00111000
   // result = 101
   CHECK_EQ(5, Handle<Smi>::cast(result.ToHandleChecked())->value());
 }
 
-namespace {
-
-Handle<JSFunction> CreateFunctionFromCode(int parameter_count_with_receiver,
-                                          Handle<Code> code) {
-  Isolate* isolate = code->GetIsolate();
-  Handle<String> name = isolate->factory()->InternalizeUtf8String("test");
-  Handle<JSFunction> function =
-      isolate->factory()->NewFunctionWithoutPrototype(name, code);
-  function->shared()->set_internal_formal_parameter_count(
-      parameter_count_with_receiver - 1);  // Implicit undefined receiver.
-  return function;
-}
-
-}  // namespace
-
 TEST(JSFunction) {
   const int kNumParams = 3;  // Receiver, left, right.
   Isolate* isolate(CcTest::InitIsolateOnce());
   CodeStubAssemblerTester m(isolate, kNumParams);
-  m.Return(m.SmiTag(m.Int32Add(m.SmiToWord32(m.Parameter(1)),
-                               m.SmiToWord32(m.Parameter(2)))));
+  m.Return(m.SmiFromWord32(m.Int32Add(m.SmiToWord32(m.Parameter(1)),
+                                      m.SmiToWord32(m.Parameter(2)))));
+
   Handle<Code> code = m.GenerateCode();
-  Handle<JSFunction> function = CreateFunctionFromCode(kNumParams, code);
-  Handle<Object> args[] = {Handle<Smi>(Smi::FromInt(23), isolate),
-                           Handle<Smi>(Smi::FromInt(34), isolate)};
-  MaybeHandle<Object> result =
-      Execution::Call(isolate, function, isolate->factory()->undefined_value(),
-                      arraysize(args), args);
+  FunctionTester ft(code, kNumParams);
+
+  MaybeHandle<Object> result = ft.Call(isolate->factory()->undefined_value(),
+                                       handle(Smi::FromInt(23), isolate),
+                                       handle(Smi::FromInt(34), isolate));
   CHECK_EQ(57, Handle<Smi>::cast(result.ToHandleChecked())->value());
 }
 
-TEST(SplitEdgeBranchMerge) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  CodeStubAssembler::Label l1(&m), merge(&m);
-  m.Branch(m.Int32Constant(1), &l1, &merge);
-  m.Bind(&l1);
-  m.Goto(&merge);
-  m.Bind(&merge);
-  USE(m.GenerateCode());
-}
-
-TEST(SplitEdgeSwitchMerge) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  CodeStubAssembler::Label l1(&m), l2(&m), l3(&m), default_label(&m);
-  CodeStubAssembler::Label* labels[] = {&l1, &l2};
-  int32_t values[] = {1, 2};
-  m.Branch(m.Int32Constant(1), &l3, &l1);
-  m.Bind(&l3);
-  m.Switch(m.Int32Constant(2), &default_label, values, labels, 2);
-  m.Bind(&l1);
-  m.Goto(&l2);
-  m.Bind(&l2);
-  m.Goto(&default_label);
-  m.Bind(&default_label);
-  USE(m.GenerateCode());
-}
-
-TEST(TestToConstant) {
-  Isolate* isolate(CcTest::InitIsolateOnce());
-  VoidDescriptor descriptor(isolate);
-  CodeStubAssemblerTester m(isolate, descriptor);
-  int32_t value32;
-  int64_t value64;
-  Node* a = m.Int32Constant(5);
-  CHECK(m.ToInt32Constant(a, value32));
-  CHECK(m.ToInt64Constant(a, value64));
-
-  a = m.Int64Constant(static_cast<int64_t>(1) << 32);
-  CHECK(!m.ToInt32Constant(a, value32));
-  CHECK(m.ToInt64Constant(a, value64));
-
-  a = m.Int64Constant(13);
-  CHECK(m.ToInt32Constant(a, value32));
-  CHECK(m.ToInt64Constant(a, value64));
-
-  a = m.UndefinedConstant();
-  CHECK(!m.ToInt32Constant(a, value32));
-  CHECK(!m.ToInt64Constant(a, value64));
-
-  a = m.UndefinedConstant();
-  CHECK(!m.ToInt32Constant(a, value32));
-  CHECK(!m.ToInt64Constant(a, value64));
-}
-
 TEST(ComputeIntegerHash) {
   Isolate* isolate(CcTest::InitIsolateOnce());
-  const int param_count = 2;
-  CodeStubAssemblerTester m(isolate, param_count);
+  const int kNumParams = 2;
+  CodeStubAssemblerTester m(isolate, kNumParams);
   m.Return(m.SmiFromWord32(m.ComputeIntegerHash(
       m.SmiToWord32(m.Parameter(0)), m.SmiToWord32(m.Parameter(1)))));
 
   Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(code, param_count);
+  FunctionTester ft(code, kNumParams);
 
   Handle<Smi> hash_seed = isolate->factory()->hash_seed();
 
   base::RandomNumberGenerator rand_gen(FLAG_random_seed);
 
   for (int i = 0; i < 1024; i++) {
     int k = rand_gen.NextInt(Smi::kMaxValue);
 
     Handle<Smi> key(Smi::FromInt(k), isolate);
     Handle<Object> result = ft.Call(key, hash_seed).ToHandleChecked();
 
     uint32_t hash = ComputeIntegerHash(k, hash_seed->value());
     Smi* expected = Smi::FromInt(hash & Smi::kMaxValue);
     CHECK_EQ(expected, Smi::cast(*result));
   }
 }
 
 TEST(TryToName) {
   typedef CodeStubAssembler::Label Label;
   typedef CodeStubAssembler::Variable Variable;
   Isolate* isolate(CcTest::InitIsolateOnce());
 
-  const int param_count = 3;
-  CodeStubAssemblerTester m(isolate, param_count);
+  const int kNumParams = 3;
+  CodeStubAssemblerTester m(isolate, kNumParams);
 
   enum Result { kKeyIsIndex, kKeyIsUnique, kBailout };
   {
     Node* key = m.Parameter(0);
     Node* expected_result = m.Parameter(1);
     Node* expected_arg = m.Parameter(2);
 
     Label passed(&m), failed(&m);
     Label if_keyisindex(&m), if_keyisunique(&m), if_bailout(&m);
     Variable var_index(&m, MachineRepresentation::kWord32);
@@ skipping 19 matching lines @@
         &passed, &failed);
 
     m.Bind(&passed);
     m.Return(m.BooleanConstant(true));
 
     m.Bind(&failed);
     m.Return(m.BooleanConstant(false));
   }
 
   Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(code, param_count);
+  FunctionTester ft(code, kNumParams);
 
   Handle<Object> expect_index(Smi::FromInt(kKeyIsIndex), isolate);
   Handle<Object> expect_unique(Smi::FromInt(kKeyIsUnique), isolate);
   Handle<Object> expect_bailout(Smi::FromInt(kBailout), isolate);
 
   {
     // TryToName(<zero smi>) => if_keyisindex: smi value.
     Handle<Object> key(Smi::FromInt(0), isolate);
     ft.CheckTrue(key, expect_index, key);
   }
@@ skipping 37 matching lines @@
 }
 
 namespace {
 
 template <typename Dictionary>
 void TestNameDictionaryLookup() {
   typedef CodeStubAssembler::Label Label;
   typedef CodeStubAssembler::Variable Variable;
   Isolate* isolate(CcTest::InitIsolateOnce());
 
-  const int param_count = 4;
-  CodeStubAssemblerTester m(isolate, param_count);
+  const int kNumParams = 4;
+  CodeStubAssemblerTester m(isolate, kNumParams);
 
   enum Result { kFound, kNotFound };
   {
     Node* dictionary = m.Parameter(0);
     Node* unique_name = m.Parameter(1);
     Node* expected_result = m.Parameter(2);
     Node* expected_arg = m.Parameter(3);
 
     Label passed(&m), failed(&m);
     Label if_found(&m), if_not_found(&m);
@@ skipping 14 matching lines @@
         &passed, &failed);
 
     m.Bind(&passed);
     m.Return(m.BooleanConstant(true));
 
     m.Bind(&failed);
     m.Return(m.BooleanConstant(false));
   }
 
   Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(code, param_count);
+  FunctionTester ft(code, kNumParams);
 
   Handle<Object> expect_found(Smi::FromInt(kFound), isolate);
   Handle<Object> expect_not_found(Smi::FromInt(kNotFound), isolate);
 
   Handle<Dictionary> dictionary = Dictionary::New(isolate, 40);
   PropertyDetails fake_details = PropertyDetails::Empty();
 
   Factory* factory = isolate->factory();
   Handle<Name> keys[] = {
       factory->InternalizeUtf8String("0"),
@@ skipping 47 matching lines @@
 TEST(GlobalDictionaryLookup) { TestNameDictionaryLookup<GlobalDictionary>(); }
 
 namespace {
 
 template <typename Dictionary>
 void TestNumberDictionaryLookup() {
   typedef CodeStubAssembler::Label Label;
   typedef CodeStubAssembler::Variable Variable;
   Isolate* isolate(CcTest::InitIsolateOnce());
 
-  const int param_count = 4;
-  CodeStubAssemblerTester m(isolate, param_count);
+  const int kNumParams = 4;
+  CodeStubAssemblerTester m(isolate, kNumParams);
 
   enum Result { kFound, kNotFound };
   {
     Node* dictionary = m.Parameter(0);
     Node* key = m.SmiToWord32(m.Parameter(1));
     Node* expected_result = m.Parameter(2);
     Node* expected_arg = m.Parameter(3);
 
     Label passed(&m), failed(&m);
     Label if_found(&m), if_not_found(&m);
@@ skipping 14 matching lines @@
         &passed, &failed);
 
     m.Bind(&passed);
     m.Return(m.BooleanConstant(true));
 
     m.Bind(&failed);
     m.Return(m.BooleanConstant(false));
   }
 
   Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(code, param_count);
+  FunctionTester ft(code, kNumParams);
 
   Handle<Object> expect_found(Smi::FromInt(kFound), isolate);
   Handle<Object> expect_not_found(Smi::FromInt(kNotFound), isolate);
 
   const int kKeysCount = 1000;
   Handle<Dictionary> dictionary = Dictionary::New(isolate, kKeysCount);
   uint32_t keys[kKeysCount];
 
   Handle<Object> fake_value(Smi::FromInt(42), isolate);
   PropertyDetails fake_details = PropertyDetails::Empty();
@@ skipping 49 matching lines @@
     JSObject::AddProperty(object, names[i], value, NONE);
   }
 }
 
 }  // namespace
 
 TEST(TryLookupProperty) {
   typedef CodeStubAssembler::Label Label;
   Isolate* isolate(CcTest::InitIsolateOnce());
 
-  const int param_count = 4;
-  CodeStubAssemblerTester m(isolate, param_count);
+  const int kNumParams = 4;
+  CodeStubAssemblerTester m(isolate, kNumParams);
 
   enum Result { kFound, kNotFound, kBailout };
   {
     Node* object = m.Parameter(0);
     Node* unique_name = m.Parameter(1);
     Node* expected_result = m.Parameter(2);
 
     Label passed(&m), failed(&m);
     Label if_found(&m), if_not_found(&m), if_bailout(&m);
 
@@ skipping 18 matching lines @@
         &passed, &failed);
 
     m.Bind(&passed);
     m.Return(m.BooleanConstant(true));
 
     m.Bind(&failed);
     m.Return(m.BooleanConstant(false));
   }
 
   Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(code, param_count);
+  FunctionTester ft(code, kNumParams);
 
   Handle<Object> expect_found(Smi::FromInt(kFound), isolate);
   Handle<Object> expect_not_found(Smi::FromInt(kNotFound), isolate);
   Handle<Object> expect_bailout(Smi::FromInt(kBailout), isolate);
 
   Factory* factory = isolate->factory();
   Handle<Name> names[] = {
       factory->InternalizeUtf8String("a"),
       factory->InternalizeUtf8String("bb"),
       factory->InternalizeUtf8String("ccc"),
@@ skipping 86 matching lines @@
                 PropertyAttributes attributes = NONE) {
   JSObject::AddDataElement(object, index, value, attributes).ToHandleChecked();
 }
 
 }  // namespace
 
 TEST(TryLookupElement) {
   typedef CodeStubAssembler::Label Label;
   Isolate* isolate(CcTest::InitIsolateOnce());
 
-  const int param_count = 4;
-  CodeStubAssemblerTester m(isolate, param_count);
+  const int kNumParams = 4;
+  CodeStubAssemblerTester m(isolate, kNumParams);
 
   enum Result { kFound, kNotFound, kBailout };
   {
     Node* object = m.Parameter(0);
     Node* index = m.SmiToWord32(m.Parameter(1));
     Node* expected_result = m.Parameter(2);
 
     Label passed(&m), failed(&m);
     Label if_found(&m), if_not_found(&m), if_bailout(&m);
 
@@ skipping 18 matching lines @@
         &passed, &failed);
 
     m.Bind(&passed);
     m.Return(m.BooleanConstant(true));
 
     m.Bind(&failed);
     m.Return(m.BooleanConstant(false));
   }
 
   Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(code, param_count);
+  FunctionTester ft(code, kNumParams);
 
   Factory* factory = isolate->factory();
   Handle<Object> smi0(Smi::FromInt(0), isolate);
   Handle<Object> smi1(Smi::FromInt(1), isolate);
   Handle<Object> smi7(Smi::FromInt(7), isolate);
   Handle<Object> smi13(Smi::FromInt(13), isolate);
   Handle<Object> smi42(Smi::FromInt(42), isolate);
 
   Handle<Object> expect_found(Smi::FromInt(kFound), isolate);
   Handle<Object> expect_not_found(Smi::FromInt(kNotFound), isolate);
@@ skipping 180 matching lines @@
   }
   m.Bind(&block1);
   CHECK(!m.GenerateCode().is_null());
 }
 
 namespace {
 
 void TestStubCacheOffsetCalculation(StubCache::Table table,
                                     Code::Kind handler_kind) {
   Isolate* isolate(CcTest::InitIsolateOnce());
-  const int param_count = 2;
-  CodeStubAssemblerTester m(isolate, param_count);
+  const int kNumParams = 2;
+  CodeStubAssemblerTester m(isolate, kNumParams);
 
   Code::Flags code_flags =
       Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(handler_kind));
   {
     Node* name = m.Parameter(0);
     Node* map = m.Parameter(1);
     Node* primary_offset = m.StubCachePrimaryOffset(name, code_flags, map);
     Node* result;
     if (table == StubCache::kPrimary) {
       result = primary_offset;
     } else {
       CHECK_EQ(StubCache::kSecondary, table);
       result = m.StubCacheSecondaryOffset(name, code_flags, primary_offset);
     }
     m.Return(m.SmiFromWord32(result));
   }
 
   Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(code, param_count);
+  FunctionTester ft(code, kNumParams);
 
   Factory* factory = isolate->factory();
   Handle<Name> names[] = {
       factory->NewSymbol(),
       factory->InternalizeUtf8String("a"),
       factory->InternalizeUtf8String("bb"),
       factory->InternalizeUtf8String("ccc"),
       factory->NewPrivateSymbol(),
       factory->InternalizeUtf8String("dddd"),
       factory->InternalizeUtf8String("eeeee"),
@@ skipping 66 matching lines @@
   m.Return(m.UndefinedConstant());
   return m.GenerateCodeCloseAndEscape();
 }
 
 }  // namespace
 
 TEST(TryProbeStubCache) {
   typedef CodeStubAssembler::Label Label;
   typedef CodeStubAssembler::Variable Variable;
   Isolate* isolate(CcTest::InitIsolateOnce());
-  const int param_count = 3;
-  CodeStubAssemblerTester m(isolate, param_count);
+  const int kNumParams = 3;
+  CodeStubAssemblerTester m(isolate, kNumParams);
 
   Code::Flags flags_to_query =
       Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC));
 
   StubCache stub_cache(isolate);
   stub_cache.Clear();
 
   {
     Node* receiver = m.Parameter(0);
     Node* name = m.Parameter(1);
@@ skipping 15 matching lines @@
                         &failed);
 
     m.Bind(&passed);
     m.Return(m.BooleanConstant(true));
 
     m.Bind(&failed);
     m.Return(m.BooleanConstant(false));
   }
 
   Handle<Code> code = m.GenerateCode();
-  FunctionTester ft(code, param_count);
+  FunctionTester ft(code, kNumParams);
 
   std::vector<Handle<Name>> names;
   std::vector<Handle<JSObject>> receivers;
   std::vector<Handle<Code>> handlers;
 
   base::RandomNumberGenerator rand_gen(FLAG_random_seed);
 
   Factory* factory = isolate->factory();
 
   // Generate some number of names.
@@ skipping 102 matching lines @@
 
     Handle<Code> expected_handler(handler, isolate);
     ft.CheckTrue(receiver, name, expected_handler);
   }
   // Ensure we performed both kind of queries.
   CHECK(queried_existing && queried_non_existing);
 }
 
 }  // namespace internal
 }  // namespace v8