Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2076953002: [turbofan] CodeAssembler is now able to generate calls of JavaScript objects. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@add-test-code-assember
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] CodeAssembler is now able to generate calls of JavaScript objects. ... and a drive-by-fix of a comment generation in CodeAssembler. Committed: https://crrev.com/6955c55321fdab714949e33a548b963473bcb4c5 Cr-Commit-Position: refs/heads/master@{#37070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -3 lines) Patch
M src/compiler/code-assembler.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 2 chunks +64 lines, -3 lines 0 comments Download
M test/cctest/compiler/function-tester.h View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-code-assembler.cc View 1 chunk +85 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076953002/1
4 years, 6 months ago (2016-06-17 13:10:51 UTC) #3
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-17 13:10:56 UTC) #5
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-17 13:27:12 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-17 13:37:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2076953002/1
4 years, 6 months ago (2016-06-17 13:47:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-17 13:49:36 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-17 13:51:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6955c55321fdab714949e33a548b963473bcb4c5
Cr-Commit-Position: refs/heads/master@{#37070}

Powered by Google App Engine
This is Rietveld 408576698