Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2072583002:
Avoid calling AXObjectCacheImpl::isAriaOwned with null parameter (Closed)
|
Created:
4 years, 6 months ago by dmazzoni Modified:
4 years, 5 months ago Reviewers:
nektarios CC:
aboxhall+watch_chromium.org, aboxhall, blink-reviews, chromium-reviews, dmazzoni+watch_chromium.org, dmazzoni, dtseng+watch_chromium.org, haraken, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@2052783002 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAvoid calling AXObjectCacheImpl::isAriaOwned with null parameter
BUG=620112
Committed: https://crrev.com/d0902478e40ef08457a0529d3e320389ff91f9b8
Cr-Commit-Position: refs/heads/master@{#402891}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 21 (8 generated)
dmazzoni@chromium.org changed reviewers: + aboxhall@chromium.org
dmazzoni@chromium.org changed reviewers: + nektar@chromium.org - aboxhall@chromium.org
bool AXObjectCacheImpl::isAriaOwned(const AXObject* child) const
{
Perhaps add a DCHECK here?
}
lgtm
The CQ bit was checked by dmazzoni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dmazzoni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by dmazzoni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Avoid calling AXObjectCacheImpl::isAriaOwned with null parameter BUG=620112 ========== to ========== Avoid calling AXObjectCacheImpl::isAriaOwned with null parameter BUG=620112 Committed: https://crrev.com/d0902478e40ef08457a0529d3e320389ff91f9b8 Cr-Commit-Position: refs/heads/master@{#402891} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d0902478e40ef08457a0529d3e320389ff91f9b8 Cr-Commit-Position: refs/heads/master@{#402891} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
