Accessibility objects with layers shouldn't be ignored

Accessibility objects with layers shouldn't be ignored.

This is a companion to http://crrev.com/2047873002/
that makes it possible to express AX object bounds
relative to paint containers. We don't want to ignore
an accessibility object if it's a paint container
that might be useful for those relative bounds.

BUG=618120
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a84253852b14fb4089913834b5af83634eaac2a0
Cr-Commit-Position: refs/heads/master@{#400206}

[dmazzoni, 2016-06-09 18:50:45]

Description was changed from

==========
Accessibility objects with layers shouldn't be ignored

BUG=618120
==========

to

==========
Accessibility objects with layers shouldn't be ignored.

This is a companion to http://crrev.com/2047873002/
that makes it possible to express AX object bounds
relative to paint containers. We don't want to ignore
an accessibility object if it's a paint container
that might be useful for those relative bounds.

BUG=618120
==========

[dmazzoni, 2016-06-09 18:50:45]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[aboxhall, 2016-06-09 23:10:42]

https://codereview.chromium.org/2052783002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/accessibility/canvas-description-and-role.html
(left):

https://codereview.chromium.org/2052783002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/accessibility/canvas-description-and-role.html:9:
<div id="container" tabIndex=0 aria-label="Container"><canvas id="canvas1"
width="100" height="100" aria-label="Canvas label">Fallback text</canvas><canvas
id="canvas2" width="100" height="100"><button>Inner
button</button></canvas><canvas id="canvas3-skipped" width="100"
height="100"></canvas></div>
Why this change?

[dmazzoni, 2016-06-10 16:15:38]

https://codereview.chromium.org/2052783002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/accessibility/canvas-description-and-role.html
(left):

https://codereview.chromium.org/2052783002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/accessibility/canvas-description-and-role.html:9:
<div id="container" tabIndex=0 aria-label="Container"><canvas id="canvas1"
width="100" height="100" aria-label="Canvas label">Fallback text</canvas><canvas
id="canvas2" width="100" height="100"><button>Inner
button</button></canvas><canvas id="canvas3-skipped" width="100"
height="100"></canvas></div>
On 2016/06/09 23:10:42, aboxhall wrote:
> Why this change?

Oh! I guess not needed. Originally I included all objects with layers and that
meant this test changed. But then I changed it to all objects with layers that
also have children, and that didn't affect any tests.

Fixed.

[aboxhall, 2016-06-13 18:46:41]

lgtm

[dmazzoni, 2016-06-13 18:54:00]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-06-13 18:54:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052783002/20001

[commit-bot: I haz the power, 2016-06-13 19:41:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 19:41:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2016-06-15 21:10:09]

Description was changed from

==========
Accessibility objects with layers shouldn't be ignored.

This is a companion to http://crrev.com/2047873002/
that makes it possible to express AX object bounds
relative to paint containers. We don't want to ignore
an accessibility object if it's a paint container
that might be useful for those relative bounds.

BUG=618120
==========

to

==========
Accessibility objects with layers shouldn't be ignored.

This is a companion to http://crrev.com/2047873002/
that makes it possible to express AX object bounds
relative to paint containers. We don't want to ignore
an accessibility object if it's a paint container
that might be useful for those relative bounds.

BUG=618120
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-06-15 21:10:19]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2016-06-15 21:10:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
aboxhall@chromium.org
Link to the patchset: https://codereview.chromium.org/2052783002/#ps40001
(title: "Fix ChromeVox test")

[commit-bot: I haz the power, 2016-06-15 21:10:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052783002/40001

[commit-bot: I haz the power, 2016-06-16 01:29:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-16 01:29:22]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dmazzoni, 2016-06-16 16:19:26]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-06-16 16:20:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052783002/40001

[commit-bot: I haz the power, 2016-06-16 18:12:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-16 18:12:32]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 18:14:00]

Description was changed from

==========
Accessibility objects with layers shouldn't be ignored.

This is a companion to http://crrev.com/2047873002/
that makes it possible to express AX object bounds
relative to paint containers. We don't want to ignore
an accessibility object if it's a paint container
that might be useful for those relative bounds.

BUG=618120
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Accessibility objects with layers shouldn't be ignored.

This is a companion to http://crrev.com/2047873002/
that makes it possible to express AX object bounds
relative to paint containers. We don't want to ignore
an accessibility object if it's a paint container
that might be useful for those relative bounds.

BUG=618120
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/a84253852b14fb4089913834b5af83634eaac2a0
Cr-Commit-Position: refs/heads/master@{#400206}
==========

[commit-bot: I haz the power, 2016-06-16 18:14:03]

Patchset 3 (id:??) landed as
https://crrev.com/a84253852b14fb4089913834b5af83634eaac2a0
Cr-Commit-Position: refs/heads/master@{#400206}