third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp - Issue 2072583002: Avoid calling AXObjectCacheImpl::isAriaOwned with null parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2072583002: Avoid calling AXObjectCacheImpl::isAriaOwned with null parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2052783002

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

index c7bf66dbb301a94c2578a01f403415b9d08ae16d..50868815477b01840f22bce2fbdd11431c10a9ce 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

@@ -1878,7 +1878,7 @@ void AXNodeObject::addChildren()

for (Node& child : NodeTraversal::childrenOf(*m_node)) {

AXObject* childObj = axObjectCache().getOrCreate(&child);

- if (!axObjectCache().isAriaOwned(childObj))

+ if (childObj && !axObjectCache().isAriaOwned(childObj))

addChild(childObj);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »