Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: chrome/browser/ui/views/sync/bubble_sync_promo_view.h

Issue 2072513003: Fix StyledLabel so it doesn't clip the bottom of Hindi text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move GetClassName Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/sync/bubble_sync_promo_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_SYNC_BUBBLE_SYNC_PROMO_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_SYNC_BUBBLE_SYNC_PROMO_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_SYNC_BUBBLE_SYNC_PROMO_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_SYNC_BUBBLE_SYNC_PROMO_VIEW_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "ui/views/controls/styled_label.h"
10 #include "ui/views/controls/styled_label_listener.h" 11 #include "ui/views/controls/styled_label_listener.h"
11 #include "ui/views/view.h"
12 12
13 class BubbleSyncPromoDelegate; 13 class BubbleSyncPromoDelegate;
14 14
15 // Bookmark sync promo displayed at the bottom of the bookmark bubble. 15 // Bookmark sync promo displayed at the bottom of the bookmark bubble.
16 class BubbleSyncPromoView : public views::StyledLabelListener, 16 class BubbleSyncPromoView : public views::StyledLabel,
17 public views::View { 17 public views::StyledLabelListener {
18 public: 18 public:
19 // |delegate| is not owned by BubbleSyncPromoView. 19 // |delegate| is not owned by BubbleSyncPromoView.
20 BubbleSyncPromoView(BubbleSyncPromoDelegate* delegate, 20 BubbleSyncPromoView(BubbleSyncPromoDelegate* delegate,
21 int link_text_resource_id, 21 int link_text_resource_id,
22 int message_text_resource_id); 22 int message_text_resource_id);
23 ~BubbleSyncPromoView() override; 23 ~BubbleSyncPromoView() override;
24 24
25 private: 25 private:
26 // views::StyledLabel:
27 const char* GetClassName() const override;
28
26 // views::StyledLabelListener: 29 // views::StyledLabelListener:
27 void StyledLabelLinkClicked(views::StyledLabel* label, 30 void StyledLabelLinkClicked(views::StyledLabel* label,
28 const gfx::Range& range, 31 const gfx::Range& range,
29 int event_flags) override; 32 int event_flags) override;
30 33
31 // views::View:
32 const char* GetClassName() const override;
33
34 // Delegate, to handle clicks on the sign in link. 34 // Delegate, to handle clicks on the sign in link.
35 BubbleSyncPromoDelegate* delegate_; 35 BubbleSyncPromoDelegate* delegate_;
36 36
37 DISALLOW_COPY_AND_ASSIGN(BubbleSyncPromoView); 37 DISALLOW_COPY_AND_ASSIGN(BubbleSyncPromoView);
38 }; 38 };
39 39
40 #endif // CHROME_BROWSER_UI_VIEWS_SYNC_BUBBLE_SYNC_PROMO_VIEW_H_ 40 #endif // CHROME_BROWSER_UI_VIEWS_SYNC_BUBBLE_SYNC_PROMO_VIEW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/sync/bubble_sync_promo_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698