Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5279)

Unified Diff: chrome/browser/ui/views/sync/bubble_sync_promo_view.h

Issue 2072513003: Fix StyledLabel so it doesn't clip the bottom of Hindi text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move GetClassName Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/sync/bubble_sync_promo_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/sync/bubble_sync_promo_view.h
diff --git a/chrome/browser/ui/views/sync/bubble_sync_promo_view.h b/chrome/browser/ui/views/sync/bubble_sync_promo_view.h
index 175dcae65643fe4af280a766a8f7f06319f6053e..d355cbf6914841e195650d6d4e8a99f1bef305d6 100644
--- a/chrome/browser/ui/views/sync/bubble_sync_promo_view.h
+++ b/chrome/browser/ui/views/sync/bubble_sync_promo_view.h
@@ -7,14 +7,14 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "ui/views/controls/styled_label.h"
#include "ui/views/controls/styled_label_listener.h"
-#include "ui/views/view.h"
class BubbleSyncPromoDelegate;
// Bookmark sync promo displayed at the bottom of the bookmark bubble.
-class BubbleSyncPromoView : public views::StyledLabelListener,
- public views::View {
+class BubbleSyncPromoView : public views::StyledLabel,
+ public views::StyledLabelListener {
public:
// |delegate| is not owned by BubbleSyncPromoView.
BubbleSyncPromoView(BubbleSyncPromoDelegate* delegate,
@@ -23,14 +23,14 @@ class BubbleSyncPromoView : public views::StyledLabelListener,
~BubbleSyncPromoView() override;
private:
+ // views::StyledLabel:
+ const char* GetClassName() const override;
+
// views::StyledLabelListener:
void StyledLabelLinkClicked(views::StyledLabel* label,
const gfx::Range& range,
int event_flags) override;
- // views::View:
- const char* GetClassName() const override;
-
// Delegate, to handle clicks on the sign in link.
BubbleSyncPromoDelegate* delegate_;
« no previous file with comments | « no previous file | chrome/browser/ui/views/sync/bubble_sync_promo_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698