Changes how window manager obtains WindowTree from mus

Changes how window manager obtains WindowTree from mus

Prior to this patch there was a WindowTree per display. This
is problematic as it means the window manager can't move windows
between displays.

This patch makes it so there is a WindowTree per window manager with
a root per display. The window manager establishes its connection by
way of WindowManagerWindowTreeFactory::CreateWindowTree(). Mus then
calls OnConnect() to give the client the client id, followed by
WmNewDisplayAdded() once per display root.

Changing this resulted in having to change around ash/mus. Previously there was
a WindowManager per display, now there is a single WindowManager with the per
display information held by RootWindowController. Ideally I would have left
these changes to a separate patch, but changing around the mojoms means I have
to do it all at once.

On the mus side there is some state held per display that needs to be upleveled
as well. To avoid making this patch even larger I'm leaving that for a future
patch. This resulted in a bit of awkwardness, but I'll fix that shortly.

BUG=611563
TEST=covered by tests
R=ben@chromium.org

Committed: https://crrev.com/1cc6966e3f846069257522bedb9c3f9315386d02
Cr-Commit-Position: refs/heads/master@{#400546}

[sky, 2016-06-17 19:48:51]

Description was changed from

==========
Changes how window manager obtains WindowTree from mus

Prior to this patch there was a WindowTree per display. This
is problematic as it means the window manager can't move windows
between displays.

This patch makes it so there is a WindowTree per window manager with
a root per display. The window manager establishes its connection by
way of WindowManagerWindowTreeFactory::CreateWindowTree(). Mus then
calls OnConnect() to give the client the client id, followed by
WmNewDisplayAdded() once per display root.

Changing this resulted in having to change around ash/mus. Previously there was
a WindowManager per display, now there is a single WindowManager with the per
display information held by RootWindowController. Ideally I would have left
these changes to a separate patch, but changing around the mojoms means I have
to do it all at once.

On the mus side there is some state held per display that needs to be upleveled
as well. To avoid making this patch even larger I'm leaving that for a future
patch. This resulted in a bit of awkwardness, but I'll fix that shortly.

BUG=611563
TEST=covered by tests
R=ben@chromium.org
==========

to

==========
Changes how window manager obtains WindowTree from mus

Prior to this patch there was a WindowTree per display. This
is problematic as it means the window manager can't move windows
between displays.

This patch makes it so there is a WindowTree per window manager with
a root per display. The window manager establishes its connection by
way of WindowManagerWindowTreeFactory::CreateWindowTree(). Mus then
calls OnConnect() to give the client the client id, followed by
WmNewDisplayAdded() once per display root.

Changing this resulted in having to change around ash/mus. Previously there was
a WindowManager per display, now there is a single WindowManager with the per
display information held by RootWindowController. Ideally I would have left
these changes to a separate patch, but changing around the mojoms means I have
to do it all at once.

On the mus side there is some state held per display that needs to be upleveled
as well. To avoid making this patch even larger I'm leaving that for a future
patch. This resulted in a bit of awkwardness, but I'll fix that shortly.

BUG=611563
TEST=covered by tests
R=ben@chromium.org
==========

[sky, 2016-06-17 19:48:51]

sky@chromium.org changed reviewers:
+ wfh@chromium.org

[sky, 2016-06-17 19:49:10]

wfh for *.mojom
ben: for rest

[Ben Goodger (Google), 2016-06-17 21:54:05]

lgtm

[Will Harris, 2016-06-17 22:24:37]

security lgtm rs for *mojom.

[sky, 2016-06-17 22:56:38]

The CQ bit was checked by sky@chromium.org

[sky, 2016-06-17 22:56:39]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/2072343002/#ps120001
(title: "include")

[commit-bot: I haz the power, 2016-06-17 22:57:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2072343002/120001

[commit-bot: I haz the power, 2016-06-17 23:59:47]

Description was changed from

==========
Changes how window manager obtains WindowTree from mus

Prior to this patch there was a WindowTree per display. This
is problematic as it means the window manager can't move windows
between displays.

This patch makes it so there is a WindowTree per window manager with
a root per display. The window manager establishes its connection by
way of WindowManagerWindowTreeFactory::CreateWindowTree(). Mus then
calls OnConnect() to give the client the client id, followed by
WmNewDisplayAdded() once per display root.

Changing this resulted in having to change around ash/mus. Previously there was
a WindowManager per display, now there is a single WindowManager with the per
display information held by RootWindowController. Ideally I would have left
these changes to a separate patch, but changing around the mojoms means I have
to do it all at once.

On the mus side there is some state held per display that needs to be upleveled
as well. To avoid making this patch even larger I'm leaving that for a future
patch. This resulted in a bit of awkwardness, but I'll fix that shortly.

BUG=611563
TEST=covered by tests
R=ben@chromium.org
==========

to

==========
Changes how window manager obtains WindowTree from mus

Prior to this patch there was a WindowTree per display. This
is problematic as it means the window manager can't move windows
between displays.

This patch makes it so there is a WindowTree per window manager with
a root per display. The window manager establishes its connection by
way of WindowManagerWindowTreeFactory::CreateWindowTree(). Mus then
calls OnConnect() to give the client the client id, followed by
WmNewDisplayAdded() once per display root.

Changing this resulted in having to change around ash/mus. Previously there was
a WindowManager per display, now there is a single WindowManager with the per
display information held by RootWindowController. Ideally I would have left
these changes to a separate patch, but changing around the mojoms means I have
to do it all at once.

On the mus side there is some state held per display that needs to be upleveled
as well. To avoid making this patch even larger I'm leaving that for a future
patch. This resulted in a bit of awkwardness, but I'll fix that shortly.

BUG=611563
TEST=covered by tests
R=ben@chromium.org
==========

[commit-bot: I haz the power, 2016-06-17 23:59:48]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-06-18 00:01:58]

Description was changed from

==========
Changes how window manager obtains WindowTree from mus

Prior to this patch there was a WindowTree per display. This
is problematic as it means the window manager can't move windows
between displays.

This patch makes it so there is a WindowTree per window manager with
a root per display. The window manager establishes its connection by
way of WindowManagerWindowTreeFactory::CreateWindowTree(). Mus then
calls OnConnect() to give the client the client id, followed by
WmNewDisplayAdded() once per display root.

Changing this resulted in having to change around ash/mus. Previously there was
a WindowManager per display, now there is a single WindowManager with the per
display information held by RootWindowController. Ideally I would have left
these changes to a separate patch, but changing around the mojoms means I have
to do it all at once.

On the mus side there is some state held per display that needs to be upleveled
as well. To avoid making this patch even larger I'm leaving that for a future
patch. This resulted in a bit of awkwardness, but I'll fix that shortly.

BUG=611563
TEST=covered by tests
R=ben@chromium.org
==========

to

==========
Changes how window manager obtains WindowTree from mus

Prior to this patch there was a WindowTree per display. This
is problematic as it means the window manager can't move windows
between displays.

This patch makes it so there is a WindowTree per window manager with
a root per display. The window manager establishes its connection by
way of WindowManagerWindowTreeFactory::CreateWindowTree(). Mus then
calls OnConnect() to give the client the client id, followed by
WmNewDisplayAdded() once per display root.

Changing this resulted in having to change around ash/mus. Previously there was
a WindowManager per display, now there is a single WindowManager with the per
display information held by RootWindowController. Ideally I would have left
these changes to a separate patch, but changing around the mojoms means I have
to do it all at once.

On the mus side there is some state held per display that needs to be upleveled
as well. To avoid making this patch even larger I'm leaving that for a future
patch. This resulted in a bit of awkwardness, but I'll fix that shortly.

BUG=611563
TEST=covered by tests
R=ben@chromium.org

Committed: https://crrev.com/1cc6966e3f846069257522bedb9c3f9315386d02
Cr-Commit-Position: refs/heads/master@{#400546}
==========

[commit-bot: I haz the power, 2016-06-18 00:02:00]

Patchset 7 (id:??) landed as
https://crrev.com/1cc6966e3f846069257522bedb9c3f9315386d02
Cr-Commit-Position: refs/heads/master@{#400546}