Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: components/mus/public/cpp/lib/window_tree_client.cc

Issue 2072343002: Changes how window manager obtains WindowTree from mus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: include Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/mus/public/cpp/lib/in_flight_change.cc ('k') | components/mus/public/cpp/tests/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/mus/public/cpp/lib/window_tree_client.cc
diff --git a/components/mus/public/cpp/lib/window_tree_client.cc b/components/mus/public/cpp/lib/window_tree_client.cc
index 5ed5eaec5c8d40b160d3158bacb485012b64075c..95c63243793a12c19c1b1d3bf5d2e0efc858402a 100644
--- a/components/mus/public/cpp/lib/window_tree_client.cc
+++ b/components/mus/public/cpp/lib/window_tree_client.cc
@@ -21,7 +21,9 @@
#include "components/mus/public/cpp/window_tracker.h"
#include "components/mus/public/cpp/window_tree_client_delegate.h"
#include "components/mus/public/cpp/window_tree_client_observer.h"
+#include "components/mus/public/interfaces/window_manager_window_tree_factory.mojom.h"
#include "services/shell/public/cpp/connector.h"
+#include "ui/display/mojo/display_type_converters.h"
#include "ui/events/event.h"
#include "ui/gfx/geometry/insets.h"
#include "ui/gfx/geometry/size.h"
@@ -94,7 +96,7 @@ WindowTreeClient::WindowTreeClient(
focused_window_(nullptr),
binding_(this),
tree_(nullptr),
- delete_on_no_roots_(true),
+ delete_on_no_roots_(!window_manager_delegate),
in_destructor_(false),
cursor_location_memory_(nullptr),
weak_factory_(this) {
@@ -143,13 +145,21 @@ void WindowTreeClient::ConnectViaWindowTreeFactory(
mojom::WindowTreeFactoryPtr factory;
connector->ConnectToInterface("mojo:mus", &factory);
- factory->CreateWindowTree(GetProxy(&tree_ptr_),
+ mojom::WindowTreePtr window_tree;
+ factory->CreateWindowTree(GetProxy(&window_tree),
binding_.CreateInterfacePtrAndBind());
- tree_ = tree_ptr_.get();
+ SetWindowTree(std::move(window_tree));
+}
- tree_ptr_->GetCursorLocationMemory(
- base::Bind(&WindowTreeClient::OnReceivedCursorLocationMemory,
- weak_factory_.GetWeakPtr()));
+void WindowTreeClient::ConnectAsWindowManager(shell::Connector* connector) {
+ DCHECK(window_manager_delegate_);
+
+ mojom::WindowManagerWindowTreeFactoryPtr factory;
+ connector->ConnectToInterface("mojo:mus", &factory);
+ mojom::WindowTreePtr window_tree;
+ factory->CreateWindowTree(GetProxy(&window_tree),
+ binding_.CreateInterfacePtrAndBind());
+ SetWindowTree(std::move(window_tree));
}
void WindowTreeClient::WaitForEmbed() {
@@ -501,6 +511,27 @@ Window* WindowTreeClient::NewWindowImpl(
return window;
}
+void WindowTreeClient::SetWindowTree(mojom::WindowTreePtr window_tree_ptr) {
+ tree_ptr_ = std::move(window_tree_ptr);
+ tree_ = tree_ptr_.get();
+
+ tree_ptr_->GetCursorLocationMemory(
+ base::Bind(&WindowTreeClient::OnReceivedCursorLocationMemory,
+ weak_factory_.GetWeakPtr()));
+
+ tree_ptr_.set_connection_error_handler(base::Bind(
+ &WindowTreeClient::OnConnectionLost, weak_factory_.GetWeakPtr()));
+
+ if (window_manager_delegate_) {
+ tree_ptr_->GetWindowManagerClient(GetProxy(&window_manager_internal_client_,
+ tree_ptr_.associated_group()));
+ }
+}
+
+void WindowTreeClient::OnConnectionLost() {
+ delete this;
+}
+
void WindowTreeClient::OnEmbedImpl(mojom::WindowTree* window_tree,
ClientSpecificId client_id,
mojom::WindowDataPtr root_data,
@@ -529,6 +560,19 @@ void WindowTreeClient::OnEmbedImpl(mojom::WindowTree* window_tree,
}
}
+void WindowTreeClient::WmNewDisplayAddedImpl(const display::Display& display,
+ mojom::WindowDataPtr root_data,
+ bool parent_drawn) {
+ DCHECK(window_manager_delegate_);
+
+ Window* root = AddWindowToClient(this, nullptr, root_data);
+ WindowPrivate(root).LocalSetDisplay(display.id());
+ WindowPrivate(root).LocalSetParentDrawn(parent_drawn);
+ roots_.insert(root);
+
+ window_manager_delegate_->OnWmNewDisplay(root, display);
+}
+
void WindowTreeClient::OnReceivedCursorLocationMemory(
mojo::ScopedSharedBufferHandle handle) {
cursor_location_handle_ = std::move(handle);
@@ -1000,6 +1044,17 @@ void WindowTreeClient::RequestClose(uint32_t window_id) {
OnRequestClose(window));
}
+void WindowTreeClient::OnConnect(ClientSpecificId client_id) {
+ client_id_ = client_id;
+}
+
+void WindowTreeClient::WmNewDisplayAdded(mojom::DisplayPtr display,
+ mojom::WindowDataPtr root_data,
+ bool parent_drawn) {
+ WmNewDisplayAddedImpl(display.To<display::Display>(), std::move(root_data),
+ parent_drawn);
+}
+
void WindowTreeClient::WmSetBounds(uint32_t change_id,
Id window_id,
const gfx::Rect& transit_bounds) {
« no previous file with comments | « components/mus/public/cpp/lib/in_flight_change.cc ('k') | components/mus/public/cpp/tests/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698