Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2072213003: The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly pro… (Closed)

Created:
4 years, 6 months ago by Shu Chen
Modified:
4 years, 6 months ago
Reviewers:
James Su
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly processing by chrome. BUG=620794 Committed: https://crrev.com/c87c4c1db691498c68b73794769ab5e4d0fc3417 Cr-Commit-Position: refs/heads/master@{#400421}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fixed test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/base/ime/input_method_chromeos.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ui/base/ime/input_method_chromeos_unittest.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Shu Chen
James, can you please take a look at this cl? Thanks.
4 years, 6 months ago (2016-06-17 09:37:53 UTC) #3
Shu Chen
James, can you please take a look at this cl? Thanks.
4 years, 6 months ago (2016-06-17 09:37:54 UTC) #4
James Su
lgtm
4 years, 6 months ago (2016-06-17 10:02:01 UTC) #5
Shu Chen
4 years, 6 months ago (2016-06-17 11:15:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072213003/20001
4 years, 6 months ago (2016-06-17 11:15:44 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/230076)
4 years, 6 months ago (2016-06-17 12:14:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2072213003/40001
4 years, 6 months ago (2016-06-17 12:59:23 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-17 13:43:41 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c87c4c1db691498c68b73794769ab5e4d0fc3417 Cr-Commit-Position: refs/heads/master@{#400421}
4 years, 6 months ago (2016-06-17 13:45:27 UTC) #16
Shu Chen
4 years, 5 months ago (2016-07-03 10:48:53 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2120133002/ by shuchen@chromium.org.

The reason for reverting is: Refer to comment #10 of crbug.com/620794:
The fix for this breaks dead key information for the fabricated key events.
.

Powered by Google App Engine
This is Rietveld 408576698