ui/base/ime/input_method_chromeos_unittest.cc - Issue 2072213003: The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly pro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method_chromeos_unittest.cc

Issue 2072213003: The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed test. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/base/ime/input_method_chromeos_unittest.cc

diff --git a/ui/base/ime/input_method_chromeos_unittest.cc b/ui/base/ime/input_method_chromeos_unittest.cc

index 83ae4df5526821ad02a0bbbb51d0085d11ab4812..7777d44c3619a5fd0f9451f00466be5a9bab89a7 100644

--- a/ui/base/ime/input_method_chromeos_unittest.cc

+++ b/ui/base/ime/input_method_chromeos_unittest.cc

@@ -969,9 +969,7 @@ TEST_F(InputMethodChromeOSKeyEventTest, DeadKeyPressTest) {

EXPECT_EQ(ET_KEY_PRESSED, key_event.type());

EXPECT_EQ(VKEY_PROCESSKEY, key_event.key_code());

- EXPECT_EQ(eventA.code(), key_event.code());

EXPECT_EQ(eventA.flags(), key_event.flags());

- EXPECT_EQ(eventA.GetDomKey(), key_event.GetDomKey());

EXPECT_EQ(eventA.time_stamp(), key_event.time_stamp());

}

« no previous file with comments | « ui/base/ime/input_method_chromeos.cc ('k') | no next file » | no next file with comments »