Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/base/ime/input_method_chromeos.cc

Issue 2072213003: The PROCESSKEY event triggered by IME should not carry the real DomKey/DomCode to avoid wrongly pro… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed test. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/base/ime/input_method_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/ime/input_method_chromeos.cc
diff --git a/ui/base/ime/input_method_chromeos.cc b/ui/base/ime/input_method_chromeos.cc
index 924c9cf968321b28c022dbe6553290bc3929d75f..03c912751664e9aa13908597fe7f7ed97014031d 100644
--- a/ui/base/ime/input_method_chromeos.cc
+++ b/ui/base/ime/input_method_chromeos.cc
@@ -25,6 +25,8 @@
#include "ui/base/ime/ime_engine_handler_interface.h"
#include "ui/base/ime/text_input_client.h"
#include "ui/events/event.h"
+#include "ui/events/keycodes/dom/dom_code.h"
+#include "ui/events/keycodes/dom/dom_key.h"
#include "ui/gfx/geometry/rect.h"
namespace {
@@ -361,9 +363,9 @@ void InputMethodChromeOS::ProcessFilteredKeyPressEvent(ui::KeyEvent* event) {
}
ui::KeyEvent fabricated_event(ET_KEY_PRESSED,
VKEY_PROCESSKEY,
- event->code(),
+ ui::DomCode::NONE,
event->flags(),
- event->GetDomKey(),
+ ui::DomKey::NONE,
event->time_stamp());
ignore_result(DispatchKeyEventPostIME(&fabricated_event));
if (fabricated_event.stopped_propagation())
« no previous file with comments | « no previous file | ui/base/ime/input_method_chromeos_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698