Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2071693002: Remove openjpeg write support. (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : remove opj_stream_set_write_function #

Patch Set 4 : rebase #

Patch Set 5 : clean up struct definition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -123 lines) Patch
M core/fxcodec/codec/codec_int.h View 1 2 3 4 2 chunks +3 lines, -6 lines 0 comments Download
M core/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 2 3 2 chunks +0 lines, -19 lines 0 comments Download
M core/fxcodec/codec/fx_codec_jpx_unittest.cpp View 1 2 3 9 chunks +8 lines, -98 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Lei Zhang
I haven't fully convinced myself that this is right. Will keep looking and just throw ...
4 years, 6 months ago (2016-06-16 00:36:06 UTC) #2
Lei Zhang
This CL is still hanging around. Shall we give it another go?
4 years, 3 months ago (2016-08-31 21:03:09 UTC) #8
Tom Sepez
On 2016/08/31 21:03:09, Lei Zhang wrote: > This CL is still hanging around. Shall we ...
4 years, 3 months ago (2016-08-31 21:06:17 UTC) #9
Lei Zhang
On 2016/08/31 21:06:17, Tom Sepez wrote: > On 2016/08/31 21:03:09, Lei Zhang wrote: > > ...
3 years, 9 months ago (2017-03-11 08:20:25 UTC) #10
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-13 17:25:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2071693002/80001
3 years, 9 months ago (2017-03-14 01:24:35 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 01:24:57 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/80e370c7d8b6541f59d98b6cbfbaae51f7e1...

Powered by Google App Engine
This is Rietveld 408576698