Remove openjpeg write support.

core/fxcodec/codec/fx_codec_jpx_unittest.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include <limits>
 
 #include "core/fxcodec/codec/codec_int.h"
 #include "testing/fx_string_testhelpers.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 static const OPJ_OFF_T kSkipError = static_cast<OPJ_OFF_T>(-1);
 static const OPJ_SIZE_T kReadError = static_cast<OPJ_SIZE_T>(-1);
-static const OPJ_SIZE_T kWriteError = static_cast<OPJ_SIZE_T>(-1);
 
-static unsigned char stream_data[] = {
+static const uint8_t stream_data[] = {
     0x00, 0x01, 0x02, 0x03,
     0x84, 0x85, 0x86, 0x87,  // Include some hi-bytes, too.
 };
 
 union Float_t {
   Float_t(float num = 0.0f) : f(num) {}
 
   int32_t i;
   FX_FLOAT f;
 };
 
 TEST(fxcodec, CMYK_Rounding) {
   // Testing all floats from 0.0 to 1.0 takes about 35 seconds in release
   // builds and much longer in debug builds, so just test the known-dangerous
   // range.
   const FX_FLOAT startValue = 0.001f;
   const FX_FLOAT endValue = 0.003f;
   FX_FLOAT R = 0.0f, G = 0.0f, B = 0.0f;
   // Iterate through floats by incrementing the representation, as discussed in
   // https://randomascii.wordpress.com/2012/01/23/stupid-float-tricks-2/
   for (Float_t f = startValue; f.f < endValue; f.i++) {
     AdobeCMYK_to_sRGB(f.f, f.f, f.f, f.f, R, G, B);
   }
   // Check various other 'special' numbers.
   AdobeCMYK_to_sRGB(0.0f, 0.25f, 0.5f, 1.0f, R, G, B);
 }
 
 TEST(fxcodec, DecodeDataNullDecodeData) {
-  unsigned char buffer[16];
+  uint8_t buffer[16];
   DecodeData* ptr = nullptr;
 
   // Error codes, not segvs, should callers pass us a nullptr pointer.
   EXPECT_EQ(kReadError, opj_read_from_memory(buffer, sizeof(buffer), ptr));
-  EXPECT_EQ(kWriteError, opj_write_from_memory(buffer, sizeof(buffer), ptr));
   EXPECT_EQ(kSkipError, opj_skip_from_memory(1, ptr));
   EXPECT_FALSE(opj_seek_from_memory(1, ptr));
 }
 
 TEST(fxcodec, DecodeDataNullStream) {
   DecodeData dd(nullptr, 0);
-  unsigned char buffer[16];
+  uint8_t buffer[16];
 
   // Reads of size 0 do nothing but return an error code.
   memset(buffer, 0xbd, sizeof(buffer));
   EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 0, &dd));
   EXPECT_EQ(0xbd, buffer[0]);
 
   // Reads of nonzero size do nothing but return an error code.
   memset(buffer, 0xbd, sizeof(buffer));
   EXPECT_EQ(kReadError, opj_read_from_memory(buffer, sizeof(buffer), &dd));
   EXPECT_EQ(0xbd, buffer[0]);
 
-  // writes of size 0 do nothing but return an error code.
-  EXPECT_EQ(kWriteError, opj_write_from_memory(buffer, 0, &dd));
-
-  // writes of nonzero size do nothing but return an error code.
-  EXPECT_EQ(kWriteError, opj_write_from_memory(buffer, sizeof(buffer), &dd));
-
   // Skips of size 0 always return an error code.
   EXPECT_EQ(kSkipError, opj_skip_from_memory(0, &dd));
 
   // Skips of nonzero size always return an error code.
   EXPECT_EQ(kSkipError, opj_skip_from_memory(1, &dd));
 
   // Seeks to 0 offset return in error.
   EXPECT_FALSE(opj_seek_from_memory(0, &dd));
 
   // Seeks to non-zero offsets return in error.
   EXPECT_FALSE(opj_seek_from_memory(1, &dd));
 }
 
 TEST(fxcodec, DecodeDataZeroSize) {
   DecodeData dd(stream_data, 0);
-  unsigned char buffer[16];
+  uint8_t buffer[16];
 
   // Reads of size 0 do nothing but return an error code.
   memset(buffer, 0xbd, sizeof(buffer));
   EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 0, &dd));
   EXPECT_EQ(0xbd, buffer[0]);
 
   // Reads of nonzero size do nothing but return an error code.
   memset(buffer, 0xbd, sizeof(buffer));
   EXPECT_EQ(kReadError, opj_read_from_memory(buffer, sizeof(buffer), &dd));
   EXPECT_EQ(0xbd, buffer[0]);
 
-  // writes of size 0 do nothing but return an error code.
-  EXPECT_EQ(kWriteError, opj_write_from_memory(buffer, 0, &dd));
-
-  // writes of nonzero size do nothing but return an error code.
-  EXPECT_EQ(kWriteError, opj_write_from_memory(buffer, sizeof(buffer), &dd));
-
   // Skips of size 0 always return an error code.
   EXPECT_EQ(kSkipError, opj_skip_from_memory(0, &dd));
 
   // Skips of nonzero size always return an error code.
   EXPECT_EQ(kSkipError, opj_skip_from_memory(1, &dd));
 
   // Seeks to 0 offset return in error.
   EXPECT_FALSE(opj_seek_from_memory(0, &dd));
 
   // Seeks to non-zero offsets return in error.
   EXPECT_FALSE(opj_seek_from_memory(1, &dd));
 }
 
 TEST(fxcodec, DecodeDataReadInBounds) {
-  unsigned char buffer[16];
+  uint8_t buffer[16];
   {
     DecodeData dd(stream_data, sizeof(stream_data));
 
     // Exact sized read in a single call.
     memset(buffer, 0xbd, sizeof(buffer));
     EXPECT_EQ(8u, opj_read_from_memory(buffer, sizeof(buffer), &dd));
     EXPECT_EQ(0x00, buffer[0]);
     EXPECT_EQ(0x01, buffer[1]);
     EXPECT_EQ(0x02, buffer[2]);
     EXPECT_EQ(0x03, buffer[3]);
@@ skipping 30 matching lines @@
     EXPECT_EQ(0xbd, buffer[6]);
 
     // Read of size 0 at EOF is still an error.
     memset(buffer, 0xbd, sizeof(buffer));
     EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 0, &dd));
     EXPECT_EQ(0xbd, buffer[0]);
   }
 }
 
 TEST(fxcodec, DecodeDataReadBeyondBounds) {
-  unsigned char buffer[16];
+  uint8_t buffer[16];
   {
     DecodeData dd(stream_data, sizeof(stream_data));
 
     // Read beyond bounds in a single step.
     memset(buffer, 0xbd, sizeof(buffer));
     EXPECT_EQ(8u, opj_read_from_memory(buffer, sizeof(buffer) + 1, &dd));
     EXPECT_EQ(0x00, buffer[0]);
     EXPECT_EQ(0x01, buffer[1]);
     EXPECT_EQ(0x02, buffer[2]);
     EXPECT_EQ(0x03, buffer[3]);
@@ skipping 42 matching lines @@
     EXPECT_EQ(0x87, buffer[1]);
     EXPECT_EQ(0xbd, buffer[2]);
 
     // Read of 6 more gets nothing and leaves rest of buffer intact.
     memset(buffer, 0xbd, sizeof(buffer));
     EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 6, &dd));
     EXPECT_EQ(0xbd, buffer[0]);
   }
 }
 
-TEST(fxcodec, DecodeDataWriteInBounds) {
-  unsigned char stream[16];
-  static unsigned char buffer_data[] = {
-      0x00, 0x01, 0x02, 0x03, 0x80, 0x80, 0x81, 0x82, 0x83, 0x84,
-  };
-  {
-    // Pretend the stream can only hold 4 bytes.
-    DecodeData dd(stream, 4);
-
-    memset(stream, 0xbd, sizeof(stream));
-    EXPECT_EQ(4u, opj_write_from_memory(buffer_data, 4, &dd));
-    EXPECT_EQ(0x00, stream[0]);
-    EXPECT_EQ(0x01, stream[1]);
-    EXPECT_EQ(0x02, stream[2]);
-    EXPECT_EQ(0x03, stream[3]);
-    EXPECT_EQ(0xbd, stream[4]);
-  }
-  {
-    // Pretend the stream can only hold 4 bytes.
-    DecodeData dd(stream, 4);
-
-    memset(stream, 0xbd, sizeof(stream));
-    EXPECT_EQ(2u, opj_write_from_memory(buffer_data, 2, &dd));
-    EXPECT_EQ(2u, opj_write_from_memory(buffer_data, 2, &dd));
-    EXPECT_EQ(0x00, stream[0]);
-    EXPECT_EQ(0x01, stream[1]);
-    EXPECT_EQ(0x00, stream[2]);
-    EXPECT_EQ(0x01, stream[3]);
-    EXPECT_EQ(0xbd, stream[4]);
-  }
-}
-
-TEST(fxcodec, DecodeDataWriteBeyondBounds) {
-  unsigned char stream[16];
-  static unsigned char buffer_data[] = {
-      0x10, 0x11, 0x12, 0x13, 0x94, 0x95, 0x96, 0x97,
-  };
-  {
-    // Pretend the stream can only hold 4 bytes.
-    DecodeData dd(stream, 4);
-
-    // Write ending past EOF transfers up til EOF.
-    memset(stream, 0xbd, sizeof(stream));
-    EXPECT_EQ(4u, opj_write_from_memory(buffer_data, 5, &dd));
-    EXPECT_EQ(0x10, stream[0]);
-    EXPECT_EQ(0x11, stream[1]);
-    EXPECT_EQ(0x12, stream[2]);
-    EXPECT_EQ(0x13, stream[3]);
-    EXPECT_EQ(0xbd, stream[4]);
-
-    // Subsequent writes fail.
-    memset(stream, 0xbd, sizeof(stream));
-    EXPECT_EQ(kWriteError, opj_write_from_memory(buffer_data, 5, &dd));
-    EXPECT_EQ(0xbd, stream[0]);
-  }
-  {
-    // Pretend the stream can only hold 4 bytes.
-    DecodeData dd(stream, 4);
-
-    // Write ending past EOF (two steps) transfers up til EOF.
-    memset(stream, 0xbd, sizeof(stream));
-    EXPECT_EQ(2u, opj_write_from_memory(buffer_data, 2, &dd));
-    EXPECT_EQ(2u, opj_write_from_memory(buffer_data, 4, &dd));
-    EXPECT_EQ(0x10, stream[0]);
-    EXPECT_EQ(0x11, stream[1]);
-    EXPECT_EQ(0x10, stream[2]);
-    EXPECT_EQ(0x11, stream[3]);
-    EXPECT_EQ(0xbd, stream[4]);
-
-    // Subsequent writes fail.
-    memset(stream, 0xbd, sizeof(stream));
-    EXPECT_EQ(kWriteError, opj_write_from_memory(buffer_data, 5, &dd));
-    EXPECT_EQ(0xbd, stream[0]);
-  }
-}
-
 // Note: Some care needs to be taken here because the skip/seek functions
 // take OPJ_OFF_T's as arguments, which are typically a signed type.
 TEST(fxcodec, DecodeDataSkip) {
-  unsigned char buffer[16];
+  uint8_t buffer[16];
   {
     DecodeData dd(stream_data, sizeof(stream_data));
 
     // Skiping within buffer is allowed.
     memset(buffer, 0xbd, sizeof(buffer));
     EXPECT_EQ(1u, opj_skip_from_memory(1, &dd));
     EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
     EXPECT_EQ(0x01, buffer[0]);
     EXPECT_EQ(0xbd, buffer[1]);
 
@@ skipping 96 matching lines @@
     EXPECT_EQ(8u, opj_skip_from_memory(8, &dd));
     EXPECT_EQ(kSkipError, opj_skip_from_memory(-4, &dd));
 
     // Next read fails.
     EXPECT_EQ(kReadError, opj_read_from_memory(buffer, 1, &dd));
     EXPECT_EQ(0xbd, buffer[0]);
   }
 }
 
 TEST(fxcodec, DecodeDataSeek) {
-  unsigned char buffer[16];
+  uint8_t buffer[16];
   DecodeData dd(stream_data, sizeof(stream_data));
 
   // Seeking within buffer is allowed and read succeeds
   memset(buffer, 0xbd, sizeof(buffer));
   EXPECT_TRUE(opj_seek_from_memory(1, &dd));
   EXPECT_EQ(1u, opj_read_from_memory(buffer, 1, &dd));
   EXPECT_EQ(0x01, buffer[0]);
   EXPECT_EQ(0xbd, buffer[1]);
 
   // Seeking before start returns error leaving position unchanged.
@@ skipping 102 matching lines @@
       EXPECT_NE(img.comps[0].h, img.comps[1].h);
       EXPECT_NE(img.comps[0].w, img.comps[2].w);
       EXPECT_NE(img.comps[0].h, img.comps[2].h);
     }
     FX_Free(img.comps[0].data);
     FX_Free(img.comps[1].data);
     FX_Free(img.comps[2].data);
   }
   FX_Free(img.comps);
 }