Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2071583003: V8: Use default compiler where possible (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Use default compiler where possible Clang is the default compiler and no explicit gyp definition is needed. This prepares for moving to MB and makes the difference between current infra-side gyp flags to new v8-side gyp flags smaller. BUG=616035 TBR=kjellander@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/200a8b341ac525c98dd8033d3205c6baaac95c27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -2523 lines) Patch
M scripts/slave/recipe_modules/v8/builders.py View 66 chunks +100 lines, -67 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_linux_release.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_dynamorio_linux_v8_dr.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json View 6 chunks +5 lines, -27 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___cfi.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json View 5 chunks +4 lines, -26 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json View 6 chunks +5 lines, -27 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json View 28 chunks +25 lines, -93 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json View 5 chunks +4 lines, -26 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_wrong_results.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json View 7 chunks +6 lines, -28 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json View 6 chunks +5 lines, -27 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___full_debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___interpreted_regexp.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___noi18n___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect.json View 16 chunks +12 lines, -103 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json View 5 chunks +4 lines, -26 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_override_changes.json View 16 chunks +12 lines, -103 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_recurring_failure.json View 10 chunks +8 lines, -53 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_tests_too_long.json View 5 chunks +4 lines, -26 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json View 16 chunks +12 lines, -103 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___swarming_staging.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___vtunejit.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Random_Deopt_Fuzzer___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___beta_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___beta_branch___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___beta_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___beta_branch___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___stable_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___stable_branch___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mips64el___sim___beta_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mips64el___sim___stable_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mipsel___sim___beta_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_mipsel___sim___stable_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc64___sim___beta_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc64___sim___stable_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc___sim___beta_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_ppc___sim___stable_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390___sim___beta_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390___sim___stable_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390x___sim___beta_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_s390x___sim___stable_branch.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___nosnap___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim___debug.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mips64el___sim___builder.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc64___sim.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc___sim.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390___sim.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390x___sim.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_dbg.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_dbg.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_gc_stress_dbg.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_dbg.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel_positional_extra_flags.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_dbg.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_avx2_dbg.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_mips64el_compile_rel.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_mipsel_compile_rel.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json View 4 chunks +3 lines, -25 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_rel.json View 3 chunks +2 lines, -24 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json View 4 chunks +3 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
PTAL. We have v8-side defaults for clang: https://cs.chromium.org/chromium/src/v8/gypfiles/standalone.gypi?l=264
4 years, 6 months ago (2016-06-16 09:41:22 UTC) #3
kjellander_chromium
I thought it was needed for the hook to download Clang but it no longer ...
4 years, 6 months ago (2016-06-16 12:49:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2071583003/1
4 years, 6 months ago (2016-06-16 12:54:28 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 12:58:22 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/200a8b341ac525c98dd8...

Powered by Google App Engine
This is Rietveld 408576698