Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json

Issue 2071583003: V8: Use default compiler where possible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
index c429d9707d4543547937a6c480e63efc02be613d..6fd85ad14f9f84c6bfd24dc2adf7cbb4bfc518fa 100644
--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json
@@ -141,7 +141,7 @@
"cwd": "[SLAVE_BUILD]/v8",
"env": {
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
- "GYP_DEFINES": "clang=1 gomadir='[CACHE]/cipd/goma' has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
+ "GYP_DEFINES": "gomadir='[CACHE]/cipd/goma' has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
"GYP_GENERATORS": "ninja",
"PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
},
@@ -217,28 +217,6 @@
]
},
{
- "allow_subannotations": true,
- "cmd": [
- "python",
- "-u",
- "RECIPE_PACKAGE_REPO[build]/scripts/slave/clang_revision.py",
- "--src-dir",
- "[SLAVE_BUILD]/v8",
- "--output-json",
- "/path/to/tmp/json"
- ],
- "env": {
- "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
- },
- "name": "clang_revision",
- "~followup_annotations": [
- "@@@STEP_LOG_LINE@json.output@{@@@",
- "@@@STEP_LOG_LINE@json.output@ \"clang_revision\": \"123456-7\"@@@",
- "@@@STEP_LOG_LINE@json.output@}@@@",
- "@@@STEP_LOG_END@json.output@@@"
- ]
- },
- {
"cmd": [
"python",
"-u",
@@ -259,7 +237,7 @@
"--build-tool",
"ninja",
"--compiler",
- "goma-clang",
+ "goma",
"--goma-jsonstatus",
"/path/to/tmp/json",
"--goma-service-account-json-file",
@@ -364,7 +342,7 @@
"builder_name": "V8 Fuzzer",
"properties": {
"parent_build_environment": {
- "GYP_DEFINES": "clang=1 has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
+ "GYP_DEFINES": "has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
"GYP_GENERATORS": "ninja"
},
"parent_got_revision": "f2cbea7e89a45f46819777bb78a1f5bd0241f64c",
@@ -388,7 +366,7 @@
"builder_name": "V8 Linux64 - debug",
"properties": {
"parent_build_environment": {
- "GYP_DEFINES": "clang=1 has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
+ "GYP_DEFINES": "has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
"GYP_GENERATORS": "ninja"
},
"parent_got_revision": "f2cbea7e89a45f46819777bb78a1f5bd0241f64c",
@@ -412,7 +390,7 @@
"builder_name": "V8 Linux64 - debug - avx2",
"properties": {
"parent_build_environment": {
- "GYP_DEFINES": "clang=1 has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
+ "GYP_DEFINES": "has_valgrind=1 jsfunfuzz=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64",
"GYP_GENERATORS": "ninja"
},
"parent_got_revision": "f2cbea7e89a45f46819777bb78a1f5bd0241f64c",

Powered by Google App Engine
This is Rietveld 408576698