Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json

Issue 2071583003: V8: Use default compiler where possible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
index 62f530f322015b71c8978a14e363e9292e2b0c0c..ff5cb20318fd5c3fc328226c8807606d485beca0 100644
--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json
@@ -141,7 +141,7 @@
"cwd": "[SLAVE_BUILD]/v8",
"env": {
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
- "GYP_DEFINES": "clang=1 gomadir='[CACHE]/cipd/goma' target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64 v8_use_external_startup_data=0",
+ "GYP_DEFINES": "gomadir='[CACHE]/cipd/goma' target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64 v8_use_external_startup_data=0",
"GYP_GENERATORS": "ninja",
"PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
},
@@ -217,28 +217,6 @@
]
},
{
- "allow_subannotations": true,
- "cmd": [
- "python",
- "-u",
- "RECIPE_PACKAGE_REPO[build]/scripts/slave/clang_revision.py",
- "--src-dir",
- "[SLAVE_BUILD]/v8",
- "--output-json",
- "/path/to/tmp/json"
- ],
- "env": {
- "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"
- },
- "name": "clang_revision",
- "~followup_annotations": [
- "@@@STEP_LOG_LINE@json.output@{@@@",
- "@@@STEP_LOG_LINE@json.output@ \"clang_revision\": \"123456-7\"@@@",
- "@@@STEP_LOG_LINE@json.output@}@@@",
- "@@@STEP_LOG_END@json.output@@@"
- ]
- },
- {
"cmd": [
"python",
"-u",
@@ -259,7 +237,7 @@
"--build-tool",
"ninja",
"--compiler",
- "goma-clang",
+ "goma",
"--goma-jsonstatus",
"/path/to/tmp/json",
"--goma-service-account-json-file",
@@ -443,7 +421,7 @@
"@@@STEP_LOG_LINE@test-name@Command: d8 test.js@@@",
"@@@STEP_LOG_LINE@test-name@@@@",
"@@@STEP_LOG_LINE@test-name@Build environment:@@@",
- "@@@STEP_LOG_LINE@test-name@ GYP_DEFINES: clang=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64 v8_use_external_startup_data=0@@@",
+ "@@@STEP_LOG_LINE@test-name@ GYP_DEFINES: target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64 v8_use_external_startup_data=0@@@",
"@@@STEP_LOG_LINE@test-name@ GYP_GENERATORS: ninja@@@",
"@@@STEP_LOG_LINE@test-name@@@@",
"@@@STEP_LOG_LINE@test-name@Run #1@@@",
@@ -473,7 +451,7 @@
"@@@STEP_LOG_LINE@test-name2@Command: d8 test.js@@@",
"@@@STEP_LOG_LINE@test-name2@@@@",
"@@@STEP_LOG_LINE@test-name2@Build environment:@@@",
- "@@@STEP_LOG_LINE@test-name2@ GYP_DEFINES: clang=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64 v8_use_external_startup_data=0@@@",
+ "@@@STEP_LOG_LINE@test-name2@ GYP_DEFINES: target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64 v8_use_external_startup_data=0@@@",
"@@@STEP_LOG_LINE@test-name2@ GYP_GENERATORS: ninja@@@",
"@@@STEP_LOG_LINE@test-name2@@@@",
"@@@STEP_LOG_LINE@test-name2@Run #1@@@",

Powered by Google App Engine
This is Rietveld 408576698