MD WebUI: Extract settings-dialog into shared cr-dialog element

MD WebUI: Extract settings-dialog into shared cr-dialog element

MD History needs to add a dialog which looks the same as
settings' dialogs. This CL moves <settings-dialog> to cr_elements as
<cr-dialog> and converts all of settings to use the new element.

BUG=618579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74
Cr-Commit-Position: refs/heads/master@{#400932}

[tsergeant, 2016-06-16 02:12:07]

Description was changed from

==========
MD WebUI: Extract settings-dialog into shared cr-dialog element

MD History needs to add a dialog which looks the same as
settings' dialogs. Sharing the same dialog element is the easist way to
achieve this.

This CL moves <settings-dialog> to cr_elements as <cr-dialog> and
converts all of settings to use the new element. It also adds a new
shared style module, 'cr-shared-style', which contains some of the
relevant styles.

BUG=618579
==========

to

==========
MD WebUI: Extract settings-dialog into shared cr-dialog element

MD History needs to add a dialog which looks the same as
settings' dialogs. Sharing the same dialog element is the easist way to
achieve this.

This CL moves <settings-dialog> to cr_elements as <cr-dialog> and
converts all of settings to use the new element. It also adds a new
shared style module, 'cr-shared-style', which contains some of the
relevant styles.

BUG=618579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-06-16 05:47:15]

Description was changed from

==========
MD WebUI: Extract settings-dialog into shared cr-dialog element

MD History needs to add a dialog which looks the same as
settings' dialogs. Sharing the same dialog element is the easist way to
achieve this.

This CL moves <settings-dialog> to cr_elements as <cr-dialog> and
converts all of settings to use the new element. It also adds a new
shared style module, 'cr-shared-style', which contains some of the
relevant styles.

BUG=618579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Extract settings-dialog into shared cr-dialog element

MD History needs to add a dialog which looks the same as
settings' dialogs. This CL moves <settings-dialog> to cr_elements as
<cr-dialog> and converts all of settings to use the new element.

BUG=618579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-06-16 05:51:21]

tsergeant@chromium.org changed reviewers:
+ dpapad@chromium.org

[tsergeant, 2016-06-16 05:51:22]

dpapad@, PTAL.

Reusing settings-dialog is the easiest way for us to add a dialog to History,
and I expect Extensions will want to use it eventually too. The conversion is
pretty straightforward, but please let me know if you have any concerns about
doing it.

[dpapad, 2016-06-16 20:53:51]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-06-16 20:53:51]

+dbeam for new cr_elements/shared_style.html

[dpapad, 2016-06-17 02:46:01]

LGTM with nit.

https://codereview.chromium.org/2071543003/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/shared_style.html (right):

https://codereview.chromium.org/2071543003/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/shared_style.html:1: <link rel="import"
href="chrome://resources/html/polymer.html">
I think the convention is to name HTML files that purely contain CSS styles with
the suffix _css.html, so this would be shared_style_css.html

[tsergeant, 2016-06-17 04:21:17]

https://codereview.chromium.org/2071543003/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/shared_style.html (right):

https://codereview.chromium.org/2071543003/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/shared_style.html:1: <link rel="import"
href="chrome://resources/html/polymer.html">
On 2016/06/17 02:46:01, dpapad wrote:
> I think the convention is to name HTML files that purely contain CSS styles
with
> the suffix _css.html, so this would be shared_style_css.html

Done.

[tsergeant, 2016-06-20 01:50:51]

ping dbeam -- can you please take a look?

[Dan Beam, 2016-06-21 05:30:35]

lgtm

https://codereview.chromium.org/2071543003/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/shared_style.html (right):

https://codereview.chromium.org/2071543003/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/shared_style.html:12: background-color: rgb(58,
117, 215);  /* 88% of --google-blue-500) */
nit: remove ) in the comment, maybe?

[tsergeant, 2016-06-21 08:07:08]

https://codereview.chromium.org/2071543003/diff/40001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/shared_style.html (right):

https://codereview.chromium.org/2071543003/diff/40001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/shared_style.html:12: background-color: rgb(58,
117, 215);  /* 88% of --google-blue-500) */
On 2016/06/21 05:30:35, Dan Beam wrote:
> nit: remove ) in the comment, maybe?

Done.

[tsergeant, 2016-06-21 08:15:53]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-06-21 08:15:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2071543003/#ps80001
(title: "Remove ) from comment")

[commit-bot: I haz the power, 2016-06-21 08:16:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2071543003/80001

[commit-bot: I haz the power, 2016-06-21 09:38:17]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-21 09:39:21]

Description was changed from

==========
MD WebUI: Extract settings-dialog into shared cr-dialog element

MD History needs to add a dialog which looks the same as
settings' dialogs. This CL moves <settings-dialog> to cr_elements as
<cr-dialog> and converts all of settings to use the new element.

BUG=618579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Extract settings-dialog into shared cr-dialog element

MD History needs to add a dialog which looks the same as
settings' dialogs. This CL moves <settings-dialog> to cr_elements as
<cr-dialog> and converts all of settings to use the new element.

BUG=618579
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74
Cr-Commit-Position: refs/heads/master@{#400932}
==========

[commit-bot: I haz the power, 2016-06-21 09:39:24]

Patchset 5 (id:??) landed as
https://crrev.com/1152c9bfedb85a1d802cfd274699d729bc7bad74
Cr-Commit-Position: refs/heads/master@{#400932}