ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js - Issue 2071543003: MD WebUI: Extract settings-dialog into shared cr-dialog element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

Issue 2071543003: MD WebUI: Extract settings-dialog into shared cr-dialog element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove ) from comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html ('k') | ui/webui/resources/cr_elements/shared_style_css.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

diff --git a/chrome/browser/resources/settings/settings_dialog.js b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

similarity index 88%

rename from chrome/browser/resources/settings/settings_dialog.js

rename to ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

index 3f587d33f70d82a5ef7ebece38d0fd6c640c1d19..33fef9b5f34e9150fc4ffbd057deb832b1288f3f 100644

--- a/chrome/browser/resources/settings/settings_dialog.js

+++ b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

@@ -3,10 +3,10 @@

// found in the LICENSE file.

/**

- * @fileoverview 'settings-dialog' is a component for showing a modal dialog.

+ * @fileoverview 'cr-dialog' is a component for showing a modal dialog.

Polymer({

- is: 'settings-dialog',

+ is: 'cr-dialog',

properties: {

/** @override */

« no previous file with comments | « ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html ('k') | ui/webui/resources/cr_elements/shared_style_css.html » ('j') | no next file with comments »