ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html - Issue 2071543003: MD WebUI: Extract settings-dialog into shared cr-dialog element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Issue 2071543003: MD WebUI: Extract settings-dialog into shared cr-dialog element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove ) from comment Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/add_site_dialog.html ('k') | ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

diff --git a/chrome/browser/resources/settings/settings_dialog.html b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

similarity index 95%

rename from chrome/browser/resources/settings/settings_dialog.html

rename to ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

index c3fded54d5f552c0dda0ee039de89778eab283e3..155293e16689da73454bfe0059398386b65488aa 100644

--- a/chrome/browser/resources/settings/settings_dialog.html

+++ b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

@@ -3,9 +3,8 @@

-<link rel="import" href="/settings_root_css.html">

-<dom-module id="settings-dialog">

+<dom-module id="cr-dialog">

:host {

@@ -102,5 +101,5 @@

</template>

- <script src="settings_dialog.js"></script>

+ <script src="cr_dialog.js"></script>

</dom-module>