Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: net/quic/quic_stream_factory.cc

Issue 2071373002: QUIC - Delete Net.QuicStreamFactory.TSVIPCliIsLoaded histogram. We have (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_stream_factory.h" 5 #include "net/quic/quic_stream_factory.h"
6 6
7 #include <openssl/aead.h> 7 #include <openssl/aead.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <tuple> 10 #include <tuple>
(...skipping 1534 matching lines...) Expand 10 before | Expand all | Expand 10 after
1545 int QuicStreamFactory::ConfigureSocket(DatagramClientSocket* socket, 1545 int QuicStreamFactory::ConfigureSocket(DatagramClientSocket* socket,
1546 IPEndPoint addr, 1546 IPEndPoint addr,
1547 NetworkHandle network) { 1547 NetworkHandle network) {
1548 if (enable_non_blocking_io_ && 1548 if (enable_non_blocking_io_ &&
1549 client_socket_factory_ == ClientSocketFactory::GetDefaultFactory()) { 1549 client_socket_factory_ == ClientSocketFactory::GetDefaultFactory()) {
1550 #if defined(OS_WIN) 1550 #if defined(OS_WIN)
1551 static_cast<UDPClientSocket*>(socket)->UseNonBlockingIO(); 1551 static_cast<UDPClientSocket*>(socket)->UseNonBlockingIO();
1552 #endif 1552 #endif
1553 } 1553 }
1554 1554
1555 #if defined(OS_WIN)
1556 // TODO(rtenneti): Delete the check for TSVIPCli.dll loaded and the histogram.
1557 bool tsvipcli_loaded = ::GetModuleHandle(L"TSVIPCli.dll") != NULL;
1558 UMA_HISTOGRAM_BOOLEAN("Net.QuicStreamFactory.TSVIPCliIsLoaded",
1559 tsvipcli_loaded);
1560 #endif
1561
1562 int rv; 1555 int rv;
1563 if (migrate_sessions_on_network_change_) { 1556 if (migrate_sessions_on_network_change_) {
1564 // If caller leaves network unspecified, use current default network. 1557 // If caller leaves network unspecified, use current default network.
1565 if (network == NetworkChangeNotifier::kInvalidNetworkHandle) { 1558 if (network == NetworkChangeNotifier::kInvalidNetworkHandle) {
1566 rv = socket->ConnectUsingDefaultNetwork(addr); 1559 rv = socket->ConnectUsingDefaultNetwork(addr);
1567 } else { 1560 } else {
1568 rv = socket->ConnectUsingNetwork(network, addr); 1561 rv = socket->ConnectUsingNetwork(network, addr);
1569 } 1562 }
1570 } else { 1563 } else {
1571 rv = socket->Connect(addr); 1564 rv = socket->Connect(addr);
(...skipping 298 matching lines...) Expand 10 before | Expand all | Expand 10 after
1870 // Since the session was active, there's no longer an 1863 // Since the session was active, there's no longer an
1871 // HttpStreamFactoryImpl::Job running which can mark it broken, unless the TCP 1864 // HttpStreamFactoryImpl::Job running which can mark it broken, unless the TCP
1872 // job also fails. So to avoid not using QUIC when we otherwise could, we mark 1865 // job also fails. So to avoid not using QUIC when we otherwise could, we mark
1873 // it as recently broken, which means that 0-RTT will be disabled but we'll 1866 // it as recently broken, which means that 0-RTT will be disabled but we'll
1874 // still race. 1867 // still race.
1875 http_server_properties_->MarkAlternativeServiceRecentlyBroken( 1868 http_server_properties_->MarkAlternativeServiceRecentlyBroken(
1876 alternative_service); 1869 alternative_service);
1877 } 1870 }
1878 1871
1879 } // namespace net 1872 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698