Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2070813002: Revert of [builtins] Introduce proper Float64Exp operator. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [builtins] Introduce proper Float64Exp operator. (patchset #5 id:80001 of https://codereview.chromium.org/2077533002/ ) Reason for revert: [Sheriff] Leads to some different rounding as it seems in some audio layout tests. Please rebase upstream first if intended: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7508 Original issue's description: > [builtins] Introduce proper Float64Exp operator. > > Import base::ieee754::exp() from FreeBSD msun and introduce a Float64Exp > TurboFan operator based on that, similar to what we do for Float64Log. > Rewrite Math.exp() as TurboFan builtin and use that operator to also > inline Math.exp() into optimized TurboFan functions. > > BUG=v8:3266, v8:3468, v8:3493, v8:5086, v8:5108 > R=mvstanton@chromium.org > > Committed: https://crrev.com/93e26314afc9da9b5b8bd998688262444ed73260 > Cr-Commit-Position: refs/heads/master@{#37037} TBR=mvstanton@chromium.org,ahaas@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3266, v8:3468, v8:3493, v8:5086, v8:5108 Committed: https://crrev.com/789b0ad77adeed58f22f422ca0b1ec51f9ede63a Cr-Commit-Position: refs/heads/master@{#37039}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1197 lines, -412 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +150 lines, -0 lines 0 comments Download
M src/arm64/codegen-arm64.h View 1 chunk +16 lines, -0 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 2 chunks +181 lines, -0 lines 0 comments Download
M src/assembler.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/assembler.cc View 5 chunks +74 lines, -6 lines 0 comments Download
M src/base/ieee754.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/base/ieee754.cc View 1 chunk +0 lines, -146 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/builtins.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/builtins.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/codegen.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/codegen.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 3 chunks +1 line, -8 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/contexts.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.h View 1 chunk +18 lines, -5 lines 0 comments Download
M src/crankshaft/arm/lithium-arm.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.h View 1 chunk +20 lines, -3 lines 0 comments Download
M src/crankshaft/arm64/lithium-arm64.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +5 lines, -10 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.h View 1 chunk +15 lines, -5 lines 0 comments Download
M src/crankshaft/ia32/lithium-ia32.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.h View 1 chunk +18 lines, -5 lines 0 comments Download
M src/crankshaft/mips/lithium-mips.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +10 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.h View 1 chunk +18 lines, -5 lines 0 comments Download
M src/crankshaft/mips64/lithium-mips64.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.h View 1 chunk +13 lines, -5 lines 0 comments Download
M src/crankshaft/x64/lithium-x64.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/external-reference-table.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +95 lines, -0 lines 0 comments Download
M src/js/math.js View 3 chunks +7 lines, -0 lines 0 comments Download
M src/mips/codegen-mips.h View 1 chunk +17 lines, -0 lines 0 comments Download
M src/mips/codegen-mips.cc View 2 chunks +143 lines, -0 lines 0 comments Download
M src/mips64/codegen-mips64.h View 1 chunk +17 lines, -0 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 2 chunks +141 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 3 chunks +7 lines, -5 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +85 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M test/unittests/base/ieee754-unittest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [builtins] Introduce proper Float64Exp operator.
4 years, 6 months ago (2016-06-16 12:47:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070813002/1
4 years, 6 months ago (2016-06-16 12:48:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 12:48:42 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 12:50:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/789b0ad77adeed58f22f422ca0b1ec51f9ede63a
Cr-Commit-Position: refs/heads/master@{#37039}

Powered by Google App Engine
This is Rietveld 408576698