Removed keeps for unused member variables.

Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us exactly 260kb in .dex size.

See https://paste.googleplex.com/6211836936454144 for a list of what
members are removed.

BUG=619937
Committed: https://crrev.com/c0c518f1ca99980f14a786a6163494136c819ed8
Cr-Commit-Position: refs/heads/master@{#402506}

[smaier, 2016-06-15 18:48:25]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-15 18:49:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070633002/1

[smaier, 2016-06-15 18:59:49]

smaier@chromium.org changed reviewers:
+ agrieve@chromium.org, wnwen@chromium.org

[smaier, 2016-06-15 18:59:49]

See https://paste.googleplex.com/6211836936454144 for the list of removed
members by this change on the final .dex file.

[smaier, 2016-06-15 19:00:43]

Description was changed from

==========
Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us TODOkb in .dex size.

BUG=619937
==========

to

==========
Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us 260kb in .dex size.

BUG=619937
==========

[smaier, 2016-06-15 19:47:30]

This keep rule was introduced in this CL:
https://chrome-internal-review.googlesource.com/#/c/174897/2

It appears that they were just trying to get proguard to work and were adding a
bunch of keep rules to try and stop things from breaking.

[commit-bot: I haz the power, 2016-06-15 19:47:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 19:47:51]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-06-16 02:42:26]

On 2016/06/15 19:47:51, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Did some grepping through the bot failure and it looks like all the failures
come down to three fields:
org.chromium.chrome.R$id.dropdown_popup_window
org.chromium.chrome.R$id.webapp_splash_space
org.chromium.chrome.R$id.find_toolbar

Two ideas for fixing:
1. Add a -keep for these three
2. compile the R.java file directly into the test jar.

I'd lean towards #2, but my first attempt at it here failed:
https://codereview.chromium.org/2069313002

[smaier, 2016-06-16 21:14:32]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-16 21:15:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070633002/20001

[commit-bot: I haz the power, 2016-06-17 01:59:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 01:59:48]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-06-18 02:27:39]

On 2016/06/17 01:59:48, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Well... #2 clearly didn't work. 

After much soul searching within aapt, I've added some comments to our
process_resources.py to explain why things are the way they are:
https://codereview.chromium.org/2081473002

I think #1 will need to be the solution here (add -keeps). but for
dropdown_popup_window, it would be better to have the tests reference the
resource through the same R class as the main binary does rather than add a
-keep.

[smaier, 2016-06-20 16:59:01]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 16:59:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070633002/40001

[commit-bot: I haz the power, 2016-06-20 17:17:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 17:17:09]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[agrieve, 2016-06-20 17:29:55]

On 2016/06/20 17:17:09, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

Had a look over the list of stripped fields:
- Majority are resource fields (R.id.foo, R.color.bar, etc). Likely these are
just unused, or used only in layout files (or maybe inlined?).
- Next up is $assertionsDisabled, which looks to be a field added by javac. Lots
of them!
- Lastly, are class constants.

In summary, the list looks great! Nothing raised any alarms to me at least.

[smaier, 2016-06-20 17:47:11]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 17:47:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070633002/60001

[smaier, 2016-06-20 17:57:07]

Description was changed from

==========
Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us 260kb in .dex size.

BUG=619937
==========

to

==========
Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us exactly 260kb in .dex size.

See https://paste.googleplex.com/6211836936454144 for a list of what members are
removed.

BUG=619937
==========

[smaier, 2016-06-20 17:57:39]

Description was changed from

==========
Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us exactly 260kb in .dex size.

See https://paste.googleplex.com/6211836936454144 for a list of what members are
removed.

BUG=619937
==========

to

==========
Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us exactly 260kb in .dex size.

See https://paste.googleplex.com/6211836936454144 for a list of what
members are removed.

BUG=619937
==========

[commit-bot: I haz the power, 2016-06-20 19:09:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 19:09:37]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[smaier, 2016-06-20 19:12:24]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-20 19:13:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070633002/80001

[commit-bot: I haz the power, 2016-06-20 20:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 20:25:41]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-06-21 01:26:36]

On 2016/06/20 20:25:41, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Well, at least it's failing for a different reason now...

[smaier, 2016-06-21 18:47:44]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 18:48:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070633002/100001

[commit-bot: I haz the power, 2016-06-21 19:50:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 19:50:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[smaier, 2016-06-22 17:15:36]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-22 17:15:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070633002/120001

[smaier, 2016-06-22 17:18:25]

smaier@chromium.org changed reviewers:
+ nyquist@chromium.org

[smaier, 2016-06-22 17:18:26]

nyquist@chromium.org: Please review changes in .../javatests/.../autofill

[commit-bot: I haz the power, 2016-06-22 18:06:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 18:06:22]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-06-23 13:56:09]

On 2016/06/22 18:06:22, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

lgtm!

[nyquist, 2016-06-24 18:44:25]

chrome/android/javatests/ lgtm

[smaier, 2016-06-27 14:46:53]

The CQ bit was checked by smaier@chromium.org

[commit-bot: I haz the power, 2016-06-27 14:47:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 14:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 14:48:54]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[smaier, 2016-06-28 17:20:45]

The CQ bit was checked by smaier@chromium.org

[smaier, 2016-06-28 17:20:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2070633002/#ps140001
(title: "Rebased")

[commit-bot: I haz the power, 2016-06-28 17:21:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 19:06:03]

Description was changed from

==========
Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us exactly 260kb in .dex size.

See https://paste.googleplex.com/6211836936454144 for a list of what
members are removed.

BUG=619937
==========

to

==========
Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us exactly 260kb in .dex size.

See https://paste.googleplex.com/6211836936454144 for a list of what
members are removed.

BUG=619937
==========

[commit-bot: I haz the power, 2016-06-28 19:06:04]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-06-28 19:07:46]

Description was changed from

==========
Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us exactly 260kb in .dex size.

See https://paste.googleplex.com/6211836936454144 for a list of what
members are removed.

BUG=619937
==========

to

==========
Removed keeps for unused member variables.

Right now, we have a very old Proguard rule that keeps around all unused
member variables for seemingly no reason at all. Removing these member
variables saves us exactly 260kb in .dex size.

See https://paste.googleplex.com/6211836936454144 for a list of what
members are removed.

BUG=619937

Committed: https://crrev.com/c0c518f1ca99980f14a786a6163494136c819ed8
Cr-Commit-Position: refs/heads/master@{#402506}
==========

[commit-bot: I haz the power, 2016-06-28 19:07:48]

Patchset 8 (id:??) landed as
https://crrev.com/c0c518f1ca99980f14a786a6163494136c819ed8
Cr-Commit-Position: refs/heads/master@{#402506}