🎂 Refactor process_resources.py to use aapt's --extra-packages

Refactor process_resources.py to use aapt's --extra-packages

We actually never pass --include-all-resources, so this is just
refactoring dead code. I think it's an improvement though,
as the new comments explain more of why things work the way they do.

BUG=none

Committed: https://crrev.com/9882d61c25bbebe84e82a7d559cae6f0807a4775
Cr-Commit-Position: refs/heads/master@{#401165}

[agrieve, 2016-06-20 14:29:06]

Description was changed from

==========
Refactor process_resources.py to use aapt's --extra-packages

We actually never pass --include-all-resources, so this is just
refactoring dead code anyways. I think it's again an improvement though,
as the new comments explain more of why things work the way they do.

BUG=none
==========

to

==========
Refactor process_resources.py to use aapt's --extra-packages

We actually never pass --include-all-resources, so this is just
refactoring dead code. I think it's an improvement though,
as the new comments explain more of why things work the way they do.

BUG=none
==========

[agrieve, 2016-06-20 14:29:06]

agrieve@chromium.org changed reviewers:
+ smaier@chromium.org, wnwen@chromium.org

[agrieve, 2016-06-20 14:29:30]

On 2016/06/20 14:29:06, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:smaier@chromium.org, mailto:wnwen@chromium.org

[smaier, 2016-06-20 15:31:40]

lgtm

lgtm

[Peter Wen, 2016-06-20 15:47:59]

lgtm

dead code refactor best refactor 🍭

[agrieve, 2016-06-20 17:46:41]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-06-20 17:46:44]

The CQ bit was unchecked by agrieve@chromium.org

[agrieve, 2016-06-20 20:38:37]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-06-20 20:38:37]

The patchset sent to the CQ was uploaded after l-g-t-m from wnwen@chromium.org,
smaier@chromium.org
Link to the patchset: https://codereview.chromium.org/2081473002/#ps40001
(title: "rebase attempt #2")

[commit-bot: I haz the power, 2016-06-20 20:39:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 20:39:11]

This CL has an open dependency (Issue 2070633002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[agrieve, 2016-06-21 01:34:02]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-06-21 01:34:03]

The patchset sent to the CQ was uploaded after l-g-t-m from wnwen@chromium.org,
smaier@chromium.org
Link to the patchset: https://codereview.chromium.org/2081473002/#ps60001
(title: "figured out why it was depending on a patchset.")

[commit-bot: I haz the power, 2016-06-21 01:34:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081473002/60001

[commit-bot: I haz the power, 2016-06-21 01:48:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 01:48:21]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-06-21 02:33:36]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 02:33:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081473002/80001

[commit-bot: I haz the power, 2016-06-21 02:51:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 02:51:30]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-06-21 16:39:50]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-06-21 16:39:50]

The patchset sent to the CQ was uploaded after l-g-t-m from wnwen@chromium.org,
smaier@chromium.org
Link to the patchset: https://codereview.chromium.org/2081473002/#ps100001
(title: "account for package name in manifest")

[commit-bot: I haz the power, 2016-06-21 16:40:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081473002/100001

[commit-bot: I haz the power, 2016-06-21 16:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 16:55:52]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-06-21 19:45:27]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-06-21 19:45:27]

The patchset sent to the CQ was uploaded after l-g-t-m from wnwen@chromium.org,
smaier@chromium.org
Link to the patchset: https://codereview.chromium.org/2081473002/#ps120001
(title: "account for no r.txt")

[commit-bot: I haz the power, 2016-06-21 19:46:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081473002/120001

[commit-bot: I haz the power, 2016-06-21 20:21:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 20:21:01]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-06-22 00:29:53]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-06-22 00:29:53]

The patchset sent to the CQ was uploaded after l-g-t-m from wnwen@chromium.org,
smaier@chromium.org
Link to the patchset: https://codereview.chromium.org/2081473002/#ps140001
(title: "ensure R.txt is always created")

[commit-bot: I haz the power, 2016-06-22 00:30:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2081473002/140001

[commit-bot: I haz the power, 2016-06-22 02:12:28]

Description was changed from

==========
Refactor process_resources.py to use aapt's --extra-packages

We actually never pass --include-all-resources, so this is just
refactoring dead code. I think it's an improvement though,
as the new comments explain more of why things work the way they do.

BUG=none
==========

to

==========
Refactor process_resources.py to use aapt's --extra-packages

We actually never pass --include-all-resources, so this is just
refactoring dead code. I think it's an improvement though,
as the new comments explain more of why things work the way they do.

BUG=none
==========

[commit-bot: I haz the power, 2016-06-22 02:12:29]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-06-22 02:16:47]

Description was changed from

==========
Refactor process_resources.py to use aapt's --extra-packages

We actually never pass --include-all-resources, so this is just
refactoring dead code. I think it's an improvement though,
as the new comments explain more of why things work the way they do.

BUG=none
==========

to

==========
Refactor process_resources.py to use aapt's --extra-packages

We actually never pass --include-all-resources, so this is just
refactoring dead code. I think it's an improvement though,
as the new comments explain more of why things work the way they do.

BUG=none

Committed: https://crrev.com/9882d61c25bbebe84e82a7d559cae6f0807a4775
Cr-Commit-Position: refs/heads/master@{#401165}
==========

[commit-bot: I haz the power, 2016-06-22 02:16:48]

Patchset 8 (id:??) landed as
https://crrev.com/9882d61c25bbebe84e82a7d559cae6f0807a4775
Cr-Commit-Position: refs/heads/master@{#401165}

[perezju, 2016-06-22 09:32:56]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2090543002/ by perezju@chromium.org.

The reason for reverting is: Broke internal android bots

https://crbug.com/622212.