Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2070523003: EDK: wait sets: Implement WaitSetDispatcher::WaitSet{AddRemove}Impl(). (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work796_wait_set_3.5
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: wait sets: Implement WaitSetDispatcher::WaitSet{AddRemove}Impl(). Still to do (separately): WaitSetWaitImpl(), hooking it up to Core, and then plumbing thunks out. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/6b0be42cd4698b3ee1e95a3a413c0a44f54d80a3

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : many fixes #

Total comments: 1

Patch Set 4 : -) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+404 lines, -26 lines) Patch
M mojo/edk/system/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.h View 1 2 3 4 chunks +71 lines, -2 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.cc View 1 2 5 chunks +244 lines, -16 lines 0 comments Download
A mojo/edk/system/wait_set_dispatcher_unittest.cc View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
Depends on https://codereview.chromium.org/2060943007.
4 years, 6 months ago (2016-06-15 21:49:32 UTC) #1
viettrungluu
ping
4 years, 6 months ago (2016-06-16 21:46:23 UTC) #2
vardhan
lgtm https://codereview.chromium.org/2070523003/diff/40001/mojo/edk/system/wait_set_dispatcher.h File mojo/edk/system/wait_set_dispatcher.h (right): https://codereview.chromium.org/2070523003/diff/40001/mojo/edk/system/wait_set_dispatcher.h#newcode135 mojo/edk/system/wait_set_dispatcher.h:135: // satisfied). nit: remove ')' also, feels unfortunate ...
4 years, 6 months ago (2016-06-17 18:03:48 UTC) #3
viettrungluu
On 2016/06/17 18:03:48, vardhan wrote: > lgtm > > https://codereview.chromium.org/2070523003/diff/40001/mojo/edk/system/wait_set_dispatcher.h > File mojo/edk/system/wait_set_dispatcher.h (right): > ...
4 years, 6 months ago (2016-06-17 19:22:04 UTC) #4
viettrungluu
4 years, 6 months ago (2016-06-17 19:22:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
6b0be42cd4698b3ee1e95a3a413c0a44f54d80a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698