EDK: wait sets: Implement WaitSetDispatcher::WaitSet{AddRemove}Impl().

EDK: wait sets: Implement WaitSetDispatcher::WaitSet{AddRemove}Impl().

Still to do (separately): WaitSetWaitImpl(), hooking it up to Core, and
then plumbing thunks out.

R=vardhan@google.com
BUG=#350

Committed: https://chromium.googlesource.com/external/mojo/+/6b0be42cd4698b3ee1e95a3a413c0a44f54d80a3

[viettrungluu, 2016-06-15 21:49:32]

Depends on https://codereview.chromium.org/2060943007.

[viettrungluu, 2016-06-16 21:46:23]

ping

[vardhan, 2016-06-17 18:03:48]

lgtm

https://codereview.chromium.org/2070523003/diff/40001/mojo/edk/system/wait_se...
File mojo/edk/system/wait_set_dispatcher.h (right):

https://codereview.chromium.org/2070523003/diff/40001/mojo/edk/system/wait_se...
mojo/edk/system/wait_set_dispatcher.h:135: // satisfied).
nit: remove ')'

also, feels unfortunate that you have to implement deque. i would've thought
//base containers have an intrusive deque, but i guess not..

[viettrungluu, 2016-06-17 19:22:04]

On 2016/06/17 18:03:48, vardhan wrote:
> lgtm
> 
>
https://codereview.chromium.org/2070523003/diff/40001/mojo/edk/system/wait_se...
> File mojo/edk/system/wait_set_dispatcher.h (right):
> 
>
https://codereview.chromium.org/2070523003/diff/40001/mojo/edk/system/wait_se...
> mojo/edk/system/wait_set_dispatcher.h:135: // satisfied).
> nit: remove ')'

Done.

> 
> also, feels unfortunate that you have to implement deque. i would've thought
> //base containers have an intrusive deque, but i guess not..

Yeah. There's also the additional complication that a) the list doesn't own its
members, b) you need to be able to do a removal of an element (starting only
direct access to the element).

[viettrungluu, 2016-06-17 19:22:14]

Description was changed from

==========
EDK: wait sets: Implement WaitSetDispatcher::WaitSet{AddRemove}Impl().

Still to do (separately): WaitSetWaitImpl(), hooking it up to Core, and
then plumbing thunks out.

R=vardhan@google.com
BUG=#350
==========

to

==========
EDK: wait sets: Implement WaitSetDispatcher::WaitSet{AddRemove}Impl().

Still to do (separately): WaitSetWaitImpl(), hooking it up to Core, and
then plumbing thunks out.

R=vardhan@google.com
BUG=#350

Committed:
https://chromium.googlesource.com/external/mojo/+/6b0be42cd4698b3ee1e95a3a413...
==========

[viettrungluu, 2016-06-17 19:22:17]

Committed patchset #4 (id:60001) manually as
6b0be42cd4698b3ee1e95a3a413c0a44f54d80a3 (presubmit successful).