Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Unified Diff: mojo/edk/system/wait_set_dispatcher_unittest.cc

Issue 2070523003: EDK: wait sets: Implement WaitSetDispatcher::WaitSet{AddRemove}Impl(). (Closed) Base URL: https://github.com/domokit/mojo.git@work796_wait_set_3.5
Patch Set: -) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/wait_set_dispatcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/wait_set_dispatcher_unittest.cc
diff --git a/mojo/edk/system/wait_set_dispatcher_unittest.cc b/mojo/edk/system/wait_set_dispatcher_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..41b6f59a3177f045bb1bd70dfc7f826a44326dbc
--- /dev/null
+++ b/mojo/edk/system/wait_set_dispatcher_unittest.cc
@@ -0,0 +1,81 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mojo/edk/system/wait_set_dispatcher.h"
+
+#include "mojo/edk/system/mock_simple_dispatcher.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using mojo::util::MakeRefCounted;
+
+namespace mojo {
+namespace system {
+namespace {
+
+TEST(WaitSetDispatcherTest, Basic) {
+ auto d = WaitSetDispatcher::Create(WaitSetDispatcher::kDefaultCreateOptions);
+
+ // These will be members of our wait set.
+ auto d_member0 = MakeRefCounted<test::MockSimpleDispatcher>(
+ MOJO_HANDLE_SIGNAL_NONE,
+ MOJO_HANDLE_SIGNAL_READABLE | MOJO_HANDLE_SIGNAL_WRITABLE);
+ auto d_member1 = MakeRefCounted<test::MockSimpleDispatcher>(
+ MOJO_HANDLE_SIGNAL_READABLE, MOJO_HANDLE_SIGNAL_READABLE);
+
+ // Add |d_member0|, for something not satisfied, but satisfiable.
+ const uint64_t kCookie0 = 0x123456789abcdef0ULL;
+ EXPECT_EQ(MOJO_RESULT_OK,
+ d->WaitSetAdd(NullUserPointer(), d_member0.Clone(),
+ MOJO_HANDLE_SIGNAL_READABLE, kCookie0));
+
+ // Add |d_member1|, for something satisfied.
+ const uint64_t kCookie1 = 0x23456789abcdef01ULL;
+ EXPECT_EQ(MOJO_RESULT_OK,
+ d->WaitSetAdd(NullUserPointer(), d_member1.Clone(),
+ MOJO_HANDLE_SIGNAL_READABLE, kCookie1));
+
+ // Can add |d_member0| again, with a different cookie.
+ const uint64_t kCookie2 = 0x3456789abcdef012ULL;
+ EXPECT_EQ(MOJO_RESULT_OK,
+ d->WaitSetAdd(NullUserPointer(), d_member0.Clone(),
+ MOJO_HANDLE_SIGNAL_WRITABLE, kCookie2));
+
+ // Adding something with the same cookie yields "already exists".
+ EXPECT_EQ(MOJO_RESULT_ALREADY_EXISTS,
+ d->WaitSetAdd(NullUserPointer(), d_member1.Clone(),
+ MOJO_HANDLE_SIGNAL_READABLE, kCookie2));
+
+ // Can remove something based on a cookie.
+ EXPECT_EQ(MOJO_RESULT_OK, d->WaitSetRemove(kCookie0));
+
+ // Trying to remove the same cookie again should fail.
+ EXPECT_EQ(MOJO_RESULT_NOT_FOUND, d->WaitSetRemove(kCookie0));
+
+ // Can re-add it.
+ EXPECT_EQ(MOJO_RESULT_OK,
+ d->WaitSetAdd(NullUserPointer(), d_member0.Clone(),
+ MOJO_HANDLE_SIGNAL_READABLE, kCookie0));
+
+ // TODO(vtl): Test waiting here.
+
+ // Can close a dispatcher that's "in" the wait set.
+ EXPECT_EQ(MOJO_RESULT_OK, d_member1->Close());
+
+ // TODO(vtl): Test waiting here.
+
+ // Can remove something whose dispatcher has been closed.
+ EXPECT_EQ(MOJO_RESULT_OK, d->WaitSetRemove(kCookie1));
+
+ // Can close the wait set when it's not empty.
+ EXPECT_EQ(MOJO_RESULT_OK, d->Close());
+
+ EXPECT_EQ(MOJO_RESULT_OK, d_member0->Close());
+}
+
+// TODO(vtl): Test options validation for "create" and "add" (not that there's
+// much to test).
+
+} // namespace
+} // namespace system
+} // namespace mojo
« no previous file with comments | « mojo/edk/system/wait_set_dispatcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698