Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2060943007: Make it possible to remove an Awakable with a specific "context" from a Dispatcher. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make it possible to remove an Awakable with a specific "context" from a Dispatcher. This will be needed for wait sets. (Before this change, removing an Awakable removed all instances of it.) R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/eabd2d1f49bc324e723700cada693689a0e333bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+250 lines, -8 lines) Patch
M mojo/edk/system/awakable_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/awakable_list.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/edk/system/awakable_list_unittest.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M mojo/edk/system/core_test_base.h View 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe.h View 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 3 chunks +20 lines, -4 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 2 chunks +29 lines, -4 lines 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_endpoint.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_endpoint.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/edk/system/simple_dispatcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/simple_dispatcher.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2070523003 Patch 1
Issue 2070523003 Patch 20001
Issue 2070523003 Patch 40001

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-15 20:23:01 UTC) #1
vardhan
lgtm
4 years, 6 months ago (2016-06-16 16:37:09 UTC) #2
viettrungluu
4 years, 6 months ago (2016-06-16 16:40:57 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
eabd2d1f49bc324e723700cada693689a0e333bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698