Remove CertTrustAnchorProvider from net

Remove CertTrustAnchorProvider from net

It has exactly one consumer, and the improved interfaces for
CertVerifier allow that to be removed from //net and the one class
in //chrome/browser/chromeos that needs it can implement it directly.

BUG=none
R=eroman@chromium.org

Committed: https://crrev.com/8daf65f2a6809a37a250226813142fc0037c734c
Cr-Commit-Position: refs/heads/master@{#400820}

[Ryan Sleevi, 2016-06-16 01:27:35]

Eric: Since you volunteered :)

[eroman, 2016-06-16 19:56:38]

lgtm!

https://codereview.chromium.org/2070223002/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/policy_cert_verifier.cc (right):

https://codereview.chromium.org/2070223002/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/policy_cert_verifier.cc:86: CertificateList
merged_trust_anchors(params.additional_trust_anchors());
How about reserving the concatenated length first?

[Ryan Sleevi, 2016-06-16 21:07:15]

https://codereview.chromium.org/2070223002/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/policy_cert_verifier.cc (right):

https://codereview.chromium.org/2070223002/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/policy_cert_verifier.cc:86: CertificateList
merged_trust_anchors(params.additional_trust_anchors());
On 2016/06/16 19:56:38, eroman wrote:
> How about reserving the concatenated length first?

.insert() does this prior to the insertion (since .begin()/.end() are
Random-Access-Iterators). Reserving it before the copy seemed an explicit
premature optimization, so I left it off lest someone think it was intentional.

[Ryan Sleevi, 2016-06-16 21:07:56]

rsleevi@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Ryan Sleevi, 2016-06-16 21:07:56]

stevenjb: More ChromeOS cleanups

[eroman, 2016-06-16 21:47:29]

https://codereview.chromium.org/2070223002/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/policy_cert_verifier.cc (right):

https://codereview.chromium.org/2070223002/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/policy_cert_verifier.cc:86: CertificateList
merged_trust_anchors(params.additional_trust_anchors());
On 2016/06/16 21:07:14, Ryan Sleevi wrote:
> On 2016/06/16 19:56:38, eroman wrote:
> > How about reserving the concatenated length first?
> 
> .insert() does this prior to the insertion (since .begin()/.end() are
> Random-Access-Iterators). Reserving it before the copy seemed an explicit
> premature optimization, so I left it off lest someone think it was
intentional.

Not quite. This does two allocations: first it copies the
additional_trust_anchors() list, then it does the insert. A common pattern is to
just reserve the full size first.

[Ryan Sleevi, 2016-06-16 21:50:36]

https://codereview.chromium.org/2070223002/diff/1/chrome/browser/chromeos/pol...
File chrome/browser/chromeos/policy/policy_cert_verifier.cc (right):

https://codereview.chromium.org/2070223002/diff/1/chrome/browser/chromeos/pol...
chrome/browser/chromeos/policy/policy_cert_verifier.cc:86: CertificateList
merged_trust_anchors(params.additional_trust_anchors());
On 2016/06/16 21:47:29, eroman wrote:
> On 2016/06/16 21:07:14, Ryan Sleevi wrote:
> > On 2016/06/16 19:56:38, eroman wrote:
> > > How about reserving the concatenated length first?
> > 
> > .insert() does this prior to the insertion (since .begin()/.end() are
> > Random-Access-Iterators). Reserving it before the copy seemed an explicit
> > premature optimization, so I left it off lest someone think it was
> intentional.
> 
> Not quite. This does two allocations: first it copies the
> additional_trust_anchors() list, then it does the insert. 

That's what I said.

> A common pattern is to just reserve the full size first.

Disagree on common, and disagree that the optimization is intrinsically
worthwhile.

[stevenjb, 2016-06-20 17:23:50]

lgtm

[Ryan Sleevi, 2016-06-20 18:52:32]

The CQ bit was checked by rsleevi@chromium.org

[commit-bot: I haz the power, 2016-06-20 18:53:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070223002/1

[commit-bot: I haz the power, 2016-06-20 18:55:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 18:55:26]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Ryan Sleevi, 2016-06-20 21:17:12]

The CQ bit was checked by rsleevi@chromium.org

[Ryan Sleevi, 2016-06-20 21:17:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2070223002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2016-06-20 21:17:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070223002/20001

[commit-bot: I haz the power, 2016-06-20 21:27:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 21:27:22]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Ryan Sleevi, 2016-06-20 21:33:41]

The CQ bit was checked by rsleevi@chromium.org

[Ryan Sleevi, 2016-06-20 21:33:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2070223002/#ps40001
(title: "Bad rebase")

[commit-bot: I haz the power, 2016-06-20 21:34:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070223002/40001

[commit-bot: I haz the power, 2016-06-20 21:51:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 21:51:30]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Ryan Sleevi, 2016-06-20 21:53:45]

The CQ bit was checked by rsleevi@chromium.org

[Ryan Sleevi, 2016-06-20 21:53:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2070223002/#ps60001
(title: "Namespace")

[commit-bot: I haz the power, 2016-06-20 21:54:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2070223002/60001

[commit-bot: I haz the power, 2016-06-20 22:59:08]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-20 23:01:01]

Description was changed from

==========
Remove CertTrustAnchorProvider from net

It has exactly one consumer, and the improved interfaces for
CertVerifier allow that to be removed from //net and the one class
in //chrome/browser/chromeos that needs it can implement it directly.

BUG=none
R=eroman@chromium.org
==========

to

==========
Remove CertTrustAnchorProvider from net

It has exactly one consumer, and the improved interfaces for
CertVerifier allow that to be removed from //net and the one class
in //chrome/browser/chromeos that needs it can implement it directly.

BUG=none
R=eroman@chromium.org

Committed: https://crrev.com/8daf65f2a6809a37a250226813142fc0037c734c
Cr-Commit-Position: refs/heads/master@{#400820}
==========

[commit-bot: I haz the power, 2016-06-20 23:01:03]

Patchset 4 (id:??) landed as
https://crrev.com/8daf65f2a6809a37a250226813142fc0037c734c
Cr-Commit-Position: refs/heads/master@{#400820}