Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Unified Diff: chrome/browser/chromeos/policy/policy_cert_verifier.cc

Issue 2070223002: Remove CertTrustAnchorProvider from net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Namespace Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/policy_cert_verifier.cc
diff --git a/chrome/browser/chromeos/policy/policy_cert_verifier.cc b/chrome/browser/chromeos/policy/policy_cert_verifier.cc
index 69d14e2a182411dbddf321c791eb8449b58fa310..88b33d43f2d34b162ad2b2b2108bac346d13ae8b 100644
--- a/chrome/browser/chromeos/policy/policy_cert_verifier.cc
+++ b/chrome/browser/chromeos/policy/policy_cert_verifier.cc
@@ -58,11 +58,8 @@ void PolicyCertVerifier::InitializeOnIOThread(
LOG(WARNING)
<< "Additional trust anchors not supported on the current platform!";
}
- std::unique_ptr<net::CachingCertVerifier> verifier =
- base::MakeUnique<net::CachingCertVerifier>(
- base::MakeUnique<net::MultiThreadedCertVerifier>(verify_proc.get()));
- verifier->SetCertTrustAnchorProvider(this);
- delegate_ = std::move(verifier);
+ delegate_ = base::MakeUnique<net::CachingCertVerifier>(
+ base::MakeUnique<net::MultiThreadedCertVerifier>(verify_proc.get()));
}
void PolicyCertVerifier::SetTrustAnchors(
@@ -85,7 +82,14 @@ int PolicyCertVerifier::Verify(
anchor_used_callback_,
completion_callback,
verify_result);
- int error = delegate_->Verify(params, crl_set, verify_result,
+
+ net::CertificateList merged_trust_anchors(params.additional_trust_anchors());
+ merged_trust_anchors.insert(merged_trust_anchors.begin(),
+ trust_anchors_.begin(), trust_anchors_.end());
+ net::CertVerifier::RequestParams new_params(
+ params.certificate(), params.hostname(), params.flags(),
+ params.ocsp_response(), merged_trust_anchors);
+ int error = delegate_->Verify(new_params, crl_set, verify_result,
wrapped_callback, out_req, net_log);
MaybeSignalAnchorUse(error, anchor_used_callback_, *verify_result);
return error;
@@ -96,9 +100,4 @@ bool PolicyCertVerifier::SupportsOCSPStapling() {
return delegate_->SupportsOCSPStapling();
}
-const net::CertificateList& PolicyCertVerifier::GetAdditionalTrustAnchors() {
- DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
- return trust_anchors_;
-}
-
} // namespace policy

Powered by Google App Engine
This is Rietveld 408576698