Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: net/cert/caching_cert_verifier_unittest.cc

Issue 2070223002: Remove CertTrustAnchorProvider from net (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Namespace Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/caching_cert_verifier.cc ('k') | net/cert/cert_trust_anchor_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/caching_cert_verifier_unittest.cc
diff --git a/net/cert/caching_cert_verifier_unittest.cc b/net/cert/caching_cert_verifier_unittest.cc
index 7b64ba3c08cbd9aa2246866a03a86e16e7f95dc4..3883f64c80efe4fa648c7166317447053a9946b2 100644
--- a/net/cert/caching_cert_verifier_unittest.cc
+++ b/net/cert/caching_cert_verifier_unittest.cc
@@ -12,7 +12,6 @@
#include "net/base/net_errors.h"
#include "net/base/test_completion_callback.h"
#include "net/base/test_data_directory.h"
-#include "net/cert/cert_trust_anchor_provider.h"
#include "net/cert/cert_verifier.h"
#include "net/cert/cert_verify_result.h"
#include "net/cert/mock_cert_verifier.h"
@@ -31,14 +30,6 @@ namespace net {
namespace {
-class MockCertTrustAnchorProvider : public CertTrustAnchorProvider {
- public:
- MockCertTrustAnchorProvider() {}
- virtual ~MockCertTrustAnchorProvider() {}
-
- MOCK_METHOD0(GetAdditionalTrustAnchors, const CertificateList&());
-};
-
class MockCacheVisitor : public CachingCertVerifier::CacheVisitor {
public:
MockCacheVisitor() {}
@@ -278,59 +269,4 @@ TEST_F(CachingCertVerifierTest, DifferentCACerts) {
ASSERT_EQ(2u, verifier_.GetCacheSize());
}
-TEST_F(CachingCertVerifierTest, CertTrustAnchorProvider) {
- MockCertTrustAnchorProvider trust_provider;
- verifier_.SetCertTrustAnchorProvider(&trust_provider);
-
- scoped_refptr<X509Certificate> test_cert(
- ImportCertFromFile(GetTestCertsDirectory(), "ok_cert.pem"));
- ASSERT_TRUE(test_cert.get());
-
- const CertificateList empty_cert_list;
- CertificateList cert_list;
- cert_list.push_back(test_cert);
-
- // Check that Verify() asks the |trust_provider| for the current list of
- // additional trust anchors.
- int error;
- CertVerifyResult verify_result;
- TestCompletionCallback callback;
- std::unique_ptr<CertVerifier::Request> request;
- EXPECT_CALL(trust_provider, GetAdditionalTrustAnchors())
- .WillOnce(ReturnRef(empty_cert_list));
- error = callback.GetResult(verifier_.Verify(
- CertVerifier::RequestParams(test_cert, "www.example.com", 0,
- std::string(), CertificateList()),
- nullptr, &verify_result, callback.callback(), &request, BoundNetLog()));
- Mock::VerifyAndClearExpectations(&trust_provider);
- EXPECT_TRUE(IsCertificateError(error));
- ASSERT_EQ(1u, verifier_.requests());
- ASSERT_EQ(0u, verifier_.cache_hits());
-
- // The next Verify() uses the cached result.
- EXPECT_CALL(trust_provider, GetAdditionalTrustAnchors())
- .WillOnce(ReturnRef(empty_cert_list));
- error = callback.GetResult(verifier_.Verify(
- CertVerifier::RequestParams(test_cert, "www.example.com", 0,
- std::string(), CertificateList()),
- nullptr, &verify_result, callback.callback(), &request, BoundNetLog()));
- Mock::VerifyAndClearExpectations(&trust_provider);
- EXPECT_TRUE(IsCertificateError(error));
- ASSERT_EQ(2u, verifier_.requests());
- ASSERT_EQ(1u, verifier_.cache_hits());
-
- // Another Verify() for the same certificate but with a different list of
- // trust anchors will not reuse the cache.
- EXPECT_CALL(trust_provider, GetAdditionalTrustAnchors())
- .WillOnce(ReturnRef(cert_list));
- error = callback.GetResult(verifier_.Verify(
- CertVerifier::RequestParams(test_cert, "www.example.com", 0,
- std::string(), CertificateList()),
- nullptr, &verify_result, callback.callback(), &request, BoundNetLog()));
- Mock::VerifyAndClearExpectations(&trust_provider);
- EXPECT_TRUE(IsCertificateError(error));
- ASSERT_EQ(3u, verifier_.requests());
- ASSERT_EQ(1u, verifier_.cache_hits());
-}
-
} // namespace net
« no previous file with comments | « net/cert/caching_cert_verifier.cc ('k') | net/cert/cert_trust_anchor_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698