Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Unified Diff: net/http/http_server_properties_impl.cc

Issue 2070203002: Remove unused HttpServerProperites::ClearAlternativeServices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@AltSvcClear
Patch Set: fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_server_properties_impl.h ('k') | net/http/http_server_properties_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_server_properties_impl.cc
diff --git a/net/http/http_server_properties_impl.cc b/net/http/http_server_properties_impl.cc
index 2b00b893010837c5d8a282971ac585684894c33d..aec1ecc5ef7239f749404cb5e5d6ddbd680ec962 100644
--- a/net/http/http_server_properties_impl.cc
+++ b/net/http/http_server_properties_impl.cc
@@ -407,9 +407,12 @@ bool HttpServerPropertiesImpl::SetAlternativeServices(
AlternativeServiceMap::iterator it = alternative_service_map_.Peek(origin);
if (alternative_service_info_vector.empty()) {
- bool found = it != alternative_service_map_.end();
- ClearAlternativeServices(origin);
- return found;
+ RemoveCanonicalHost(origin);
+ if (it == alternative_service_map_.end())
+ return false;
+
+ alternative_service_map_.Erase(it);
+ return true;
}
bool changed = true;
@@ -508,17 +511,6 @@ void HttpServerPropertiesImpl::ConfirmAlternativeService(
recently_broken_alternative_services_.erase(alternative_service);
}
-void HttpServerPropertiesImpl::ClearAlternativeServices(
- const url::SchemeHostPort& origin) {
- RemoveCanonicalHost(origin);
-
- AlternativeServiceMap::iterator it = alternative_service_map_.Peek(origin);
- if (it == alternative_service_map_.end()) {
- return;
- }
- alternative_service_map_.Erase(it);
-}
-
const AlternativeServiceMap& HttpServerPropertiesImpl::alternative_service_map()
const {
return alternative_service_map_;
« no previous file with comments | « net/http/http_server_properties_impl.h ('k') | net/http/http_server_properties_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698