Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2070003002: V8: Let peek-gn use mb to reuse v8-side configs. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Let peek-gn use mb to reuse v8-side configs. The infra-side gn step requires infra-side configs. These will be moved into the v8 repository for using mb. In order to not duplicate them, let the peek-gn step also use mb. It'll use gn for all bots by patching the mb config on the fly. BUG=616035 Committed: https://chromium.googlesource.com/chromium/tools/build/+/df9e7026a81361939f4a213243c123b9f3766cbd

Patch Set 1 #

Total comments: 6

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2449 lines, -502 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 3 chunks +7 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/v8/api.py View 1 chunk +21 lines, -2 lines 0 comments Download
A scripts/slave/recipe_modules/v8/resources/patch_mb_config.py View 1 1 chunk +15 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_dart_fyi_v8_linux_release.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_dynamorio_linux_v8_dr.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN___debug_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_arm64___debug_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_no_inline___release_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_TSAN.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___cfi.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___gcov_coverage.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_empty_json.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_one_failure.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures.json View 3 chunks +78 lines, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_flakes.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___internal_snapshot_test_failures_wrong_results.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_arm___debug_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_ASAN_mipsel___debug_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___arm64___sim___MSAN.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___full_debug.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___interpreted_regexp.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___noi18n___debug.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap_debug_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect.json View 4 chunks +105 lines, -20 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_one_change.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_override_changes.json View 4 chunks +105 lines, -20 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_recurring_failure.json View 2 chunks +51 lines, -10 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___predictable_bisect_tests_too_long.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___shared_bisect_swarming.json View 4 chunks +105 lines, -20 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___swarming_staging.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___vtunejit.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_gcc_4_8.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___beta_branch.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___beta_branch___debug.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch___debug.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch___debug.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch___debug.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___debug.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___gc_stress.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm64___sim___nosnap___debug.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___arm___sim___debug.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mips64el___sim___builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___mipsel___sim___builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc64___sim.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___ppc___sim.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390___sim.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___s390x___sim.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug_builder.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_asan_rel_ng.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_dbg.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_avx2_rel_ng.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_msan_rel.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_sanitizer_coverage_rel.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_tsan_rel.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_dbg.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_gc_stress_dbg.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm64_rel_ng.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_dbg.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_armv8a_rel_positional_extra_flags.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_dbg.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_arm_rel_ng.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_avx2_dbg.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gc_stress_dbg.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_compile_rel.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_gcc_rel.json View 1 chunk +22 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_mips64el_compile_rel.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_mipsel_compile_rel.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nodcheck_rel_ng.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_noi18n_rel_ng.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_dbg.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_nosnap_rel.json View 1 chunk +24 lines, -5 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng.json View 1 chunk +24 lines, -5 lines 0 comments Download

Depends on Patchset:

Issue 2068183002 Patch 1

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2070003002/diff/1/scripts/slave/recipe_modules/chromium/api.py File scripts/slave/recipe_modules/chromium/api.py (right): https://codereview.chromium.org/2070003002/diff/1/scripts/slave/recipe_modules/chromium/api.py#newcode645 scripts/slave/recipe_modules/chromium/api.py:645: kwargs.update(kwargs_override) Need this to pass ok_ret=any https://codereview.chromium.org/2070003002/diff/1/scripts/slave/recipe_modules/v8/resources/patch_mb_config.py File ...
4 years, 6 months ago (2016-06-15 14:44:37 UTC) #3
tandrii(chromium)
LGTM % suggestion https://codereview.chromium.org/2070003002/diff/1/scripts/slave/recipe_modules/chromium/api.py File scripts/slave/recipe_modules/chromium/api.py (right): https://codereview.chromium.org/2070003002/diff/1/scripts/slave/recipe_modules/chromium/api.py#newcode645 scripts/slave/recipe_modules/chromium/api.py:645: kwargs.update(kwargs_override) On 2016/06/15 14:44:37, Michael Achenbach ...
4 years, 6 months ago (2016-06-15 15:25:37 UTC) #4
Michael Achenbach
https://codereview.chromium.org/2070003002/diff/1/scripts/slave/recipe_modules/chromium/api.py File scripts/slave/recipe_modules/chromium/api.py (right): https://codereview.chromium.org/2070003002/diff/1/scripts/slave/recipe_modules/chromium/api.py#newcode645 scripts/slave/recipe_modules/chromium/api.py:645: kwargs.update(kwargs_override) On 2016/06/15 15:25:37, tandrii(chromium) wrote: > On 2016/06/15 ...
4 years, 6 months ago (2016-06-15 15:58:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2070003002/20001
4 years, 6 months ago (2016-06-15 15:58:32 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 16:03:35 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/df9e7026a81361939f4a...

Powered by Google App Engine
This is Rietveld 408576698