scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json - Issue 2070003002: V8: Let peek-gn use mb to reuse v8-side configs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json

Issue 2070003002: V8: Let peek-gn use mb to reuse v8-side configs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Review Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___arm64___sim___MSAN.json ('k') | scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug_builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json

diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json

index 89acea2d5724be076120bd087991ee9718b0e264..98c00c6bde5b5a7b6a6c29d9a3557bf3db842a63 100644

--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json

+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___builder.json

@@ -162,13 +162,32 @@

"cmd": [

"python",

"-u",

- "[DEPOT_TOOLS]/gn.py",

- "--root=[SLAVE_BUILD]/v8",

+ "RECIPE_MODULE[build::v8]/resources/patch_mb_config.py",

+ "[SLAVE_BUILD]/v8/infra/mb/mb_config.pyl",

+ "/path/to/tmp/"

+ ],

+ "name": "patch mb config (fyi)"

+ },

+ {

+ "cmd": [

+ "python",

+ "-u",

+ "[SLAVE_BUILD]/v8/tools/mb/mb.py",

"gen",

- "[TMP_BASE]/v8_gn_tmp_1",

- "--args=is_debug=false target_cpu=\"x86\" use_goma=true goma_dir=\"[CACHE]/cipd/goma\""

+ "-m",

+ "client.v8",

+ "-b",

+ "V8 Linux - builder",

+ "--config-file",

+ "[mb config]",

+ "--goma-dir",

+ "[CACHE]/cipd/goma",

+ "[TMP_BASE]/v8_gn_tmp_1"

- "name": "gn"

+ "env": {

+ "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

+ },

+ "name": "generate_build_files with gn (fyi)"

{

"cmd": [