| OLD | NEW |
| 1 # Copyright 2013 The Chromium Authors. All rights reserved. | 1 # Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 import argparse | 5 import argparse |
| 6 import datetime | 6 import datetime |
| 7 import random | 7 import random |
| 8 import re | 8 import re |
| 9 import urllib | 9 import urllib |
| 10 | 10 |
| (...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 270 self.m.chromium.runhooks(env=env, **kwargs) | 270 self.m.chromium.runhooks(env=env, **kwargs) |
| 271 | 271 |
| 272 def peek_gn(self): | 272 def peek_gn(self): |
| 273 """Runs gn and compares flags with gyp (fyi only).""" | 273 """Runs gn and compares flags with gyp (fyi only).""" |
| 274 # TODO(machenbach): Whitelist all builders eventually. | 274 # TODO(machenbach): Whitelist all builders eventually. |
| 275 if 'linux' not in self.m.properties['buildername'].lower(): | 275 if 'linux' not in self.m.properties['buildername'].lower(): |
| 276 return | 276 return |
| 277 gyp_build_dir = self.m.chromium.c.build_dir.join( | 277 gyp_build_dir = self.m.chromium.c.build_dir.join( |
| 278 self.m.chromium.c.build_config_fs) | 278 self.m.chromium.c.build_config_fs) |
| 279 with self.m.tempfile.temp_dir('v8_gn') as gn_build_dir: | 279 with self.m.tempfile.temp_dir('v8_gn') as gn_build_dir: |
| 280 self.m.chromium.run_gn( | 280 step_result = self.m.python( |
| 281 use_goma=True, build_dir=gn_build_dir, ok_ret='any') | 281 name='patch mb config (fyi)', |
| 282 script=self.resource('patch_mb_config.py'), |
| 283 args=[ |
| 284 self.m.path['checkout'].join('infra', 'mb', 'mb_config.pyl'), |
| 285 self.m.raw_io.output(), |
| 286 ], |
| 287 step_test_data=lambda: self.m.raw_io.test_api.output('[mb config]'), |
| 288 ok_ret='any', |
| 289 ) |
| 290 use_goma = (self.m.chromium.c.compile_py.compiler and |
| 291 'goma' in self.m.chromium.c.compile_py.compiler) |
| 292 self.m.chromium.run_mb( |
| 293 self.m.properties['mastername'], |
| 294 self.m.properties['buildername'], |
| 295 name='generate_build_files with gn (fyi)', |
| 296 use_goma=use_goma, |
| 297 mb_config_path=self.m.raw_io.input(step_result.raw_io.output), |
| 298 build_dir=gn_build_dir, |
| 299 ok_ret='any', |
| 300 ) |
| 282 self.m.python( | 301 self.m.python( |
| 283 'compare build flags (fyi)', | 302 'compare build flags (fyi)', |
| 284 self.m.path['checkout'].join('tools', 'gyp_flag_compare.py'), | 303 self.m.path['checkout'].join('tools', 'gyp_flag_compare.py'), |
| 285 [gn_build_dir, gyp_build_dir, 'all', 'all'], | 304 [gn_build_dir, gyp_build_dir, 'all', 'all'], |
| 286 ok_ret='any', | 305 ok_ret='any', |
| 287 ) | 306 ) |
| 288 | 307 |
| 289 @property | 308 @property |
| 290 def build_environment(self): | 309 def build_environment(self): |
| 291 if self.m.properties.get('parent_build_environment'): | 310 if self.m.properties.get('parent_build_environment'): |
| (...skipping 869 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1161 def report_culprits(self, culprit_range): | 1180 def report_culprits(self, culprit_range): |
| 1162 assert culprit_range | 1181 assert culprit_range |
| 1163 if len(culprit_range) > 1: | 1182 if len(culprit_range) > 1: |
| 1164 text = 'Suspecting multiple commits' | 1183 text = 'Suspecting multiple commits' |
| 1165 else: | 1184 else: |
| 1166 text = 'Suspecting %s' % culprit_range[0][:8] | 1185 text = 'Suspecting %s' % culprit_range[0][:8] |
| 1167 | 1186 |
| 1168 step_result = self.m.step(text, cmd=None) | 1187 step_result = self.m.step(text, cmd=None) |
| 1169 for culprit in culprit_range: | 1188 for culprit in culprit_range: |
| 1170 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit | 1189 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit |
| OLD | NEW |