Rebaseline the actual missing results only

Rebaseline the actual missing results only

Previously we tried to rebaseline all txt, png and wav results for a
test with MISSING actual results. This caused out-dated results were
used for non-missing results because the "latest layout test results"
storage server contains the latest failure of each test of all recent
runs.

BUG=613660
Committed: https://crrev.com/a28604ed1b4ebe103318e80f14171ffcc656c2bc
Cr-Commit-Position: refs/heads/master@{#399776}

[Xianzhu, 2016-06-14 18:54:59]

wangxianzhu@chromium.org changed reviewers:
+ wkorman@chromium.org

[Xianzhu, 2016-06-14 18:57:56]

The refactory in layouttestresults.py is to make it possible to pass the whole
test result (in LayoutTestResult) to
TestExpectations.suffixes_for_test_result().

Other changes are just passive changes because of the refactory.

[wkorman, 2016-06-14 19:09:19]

lgtm

Thank you. Crazy. I wonder whether the server output changed, and it used to do
what the code expected. Well, it will be better henceforth.

https://codereview.chromium.org/2069743002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
(right):

https://codereview.chromium.org/2069743002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:973:
def suffixes_for_test_result(test_result):
Could potentially add unit tests for this and buildbot_results but I see both
are light in tests already and the other tests you added probably indirectly
cover.

https://codereview.chromium.org/2069743002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
(right):

https://codereview.chromium.org/2069743002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:838:
def disabled_test_rebaseline_missing(self):
Intentionally disabled?

[Xianzhu, 2016-06-14 19:23:21]

https://codereview.chromium.org/2069743002/diff/1/third_party/WebKit/Tools/Sc...
File
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py
(right):

https://codereview.chromium.org/2069743002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:838:
def disabled_test_rebaseline_missing(self):
On 2016/06/14 19:09:19, wkorman wrote:
> Intentionally disabled?

Yes, along with other rebaseline tests because we disabled rebaseline
temporarily.

This test passes with rebaseline enabled.

[Xianzhu, 2016-06-14 19:23:25]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-06-14 19:23:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2069743002/1

[commit-bot: I haz the power, 2016-06-14 20:21:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-14 20:21:51]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 20:24:20]

Description was changed from

==========
Rebaseline the actual missing results only

Previously we tried to rebaseline all txt, png and wav results for a
test with MISSING actual results. This caused out-dated results were
used for non-missing results because the "latest layout test results"
storage server contains the latest failure of each test of all recent
runs.

BUG=613660
==========

to

==========
Rebaseline the actual missing results only

Previously we tried to rebaseline all txt, png and wav results for a
test with MISSING actual results. This caused out-dated results were
used for non-missing results because the "latest layout test results"
storage server contains the latest failure of each test of all recent
runs.

BUG=613660

Committed: https://crrev.com/a28604ed1b4ebe103318e80f14171ffcc656c2bc
Cr-Commit-Position: refs/heads/master@{#399776}
==========

[commit-bot: I haz the power, 2016-06-14 20:24:21]

Patchset 1 (id:??) landed as
https://crrev.com/a28604ed1b4ebe103318e80f14171ffcc656c2bc
Cr-Commit-Position: refs/heads/master@{#399776}

[Dirk Pranke, 2016-06-14 21:03:50]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-06-14 21:03:50]

+qyearsley fyi ...