Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 2069743002: Rebaseline the actual missing results only (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2010 Google Inc. All rights reserved. 1 # Copyright (c) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 510
511 if options.optimize: 511 if options.optimize:
512 # TODO(wkorman): Consider changing temporary branch to base off of H EAD rather than 512 # TODO(wkorman): Consider changing temporary branch to base off of H EAD rather than
513 # origin/master to ensure we run baseline optimization processes wit h the same code as 513 # origin/master to ensure we run baseline optimization processes wit h the same code as
514 # auto-rebaseline itself. 514 # auto-rebaseline itself.
515 self._run_in_parallel_and_update_scm(self._optimize_baselines(test_p refix_list, options.verbose)) 515 self._run_in_parallel_and_update_scm(self._optimize_baselines(test_p refix_list, options.verbose))
516 516
517 def _suffixes_for_actual_failures(self, test, builder_name, existing_suffixe s): 517 def _suffixes_for_actual_failures(self, test, builder_name, existing_suffixe s):
518 if builder_name not in self.builder_data(): 518 if builder_name not in self.builder_data():
519 return set() 519 return set()
520 actual_results = self.builder_data()[builder_name].actual_results(test) 520 test_result = self.builder_data()[builder_name].result_for_test(test)
521 if not actual_results: 521 if not test_result:
522 return set() 522 return set()
523 return set(existing_suffixes) & TestExpectations.suffixes_for_actual_exp ectations_string(actual_results) 523 return set(existing_suffixes) & TestExpectations.suffixes_for_test_resul t(test_result)
524 524
525 525
526 class RebaselineJson(AbstractParallelRebaselineCommand): 526 class RebaselineJson(AbstractParallelRebaselineCommand):
527 name = "rebaseline-json" 527 name = "rebaseline-json"
528 help_text = "Rebaseline based off JSON passed to stdin. Intended to only be called from other scripts." 528 help_text = "Rebaseline based off JSON passed to stdin. Intended to only be called from other scripts."
529 529
530 def __init__(self,): 530 def __init__(self,):
531 super(RebaselineJson, self).__init__(options=[ 531 super(RebaselineJson, self).__init__(options=[
532 self.no_optimize_option, 532 self.no_optimize_option,
533 self.results_directory_option, 533 self.results_directory_option,
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
907 issue_already_closed = tool.executive.run_command( 907 issue_already_closed = tool.executive.run_command(
908 ['git', 'config', 'branch.%s.rietveldissue' % rebaseline _branch_name], 908 ['git', 'config', 'branch.%s.rietveldissue' % rebaseline _branch_name],
909 return_exit_code=True) 909 return_exit_code=True)
910 if not issue_already_closed: 910 if not issue_already_closed:
911 self._run_git_cl_command(options, ['set_close']) 911 self._run_git_cl_command(options, ['set_close'])
912 912
913 tool.scm().ensure_cleanly_tracking_remote_master() 913 tool.scm().ensure_cleanly_tracking_remote_master()
914 if old_branch_name_or_ref: 914 if old_branch_name_or_ref:
915 tool.scm().checkout_branch(old_branch_name_or_ref) 915 tool.scm().checkout_branch(old_branch_name_or_ref)
916 tool.scm().delete_branch(rebaseline_branch_name) 916 tool.scm().delete_branch(rebaseline_branch_name)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698