Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

Issue 2069743002: Rebaseline the actual missing results only (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
index 94e8f2ae09d46d6b49bc04e703f4a457c891d71d..358fa4cf7a3ae3f34ad2ba60d2b66093ec0caa97 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py
@@ -517,10 +517,10 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
def _suffixes_for_actual_failures(self, test, builder_name, existing_suffixes):
if builder_name not in self.builder_data():
return set()
- actual_results = self.builder_data()[builder_name].actual_results(test)
- if not actual_results:
+ test_result = self.builder_data()[builder_name].result_for_test(test)
+ if not test_result:
return set()
- return set(existing_suffixes) & TestExpectations.suffixes_for_actual_expectations_string(actual_results)
+ return set(existing_suffixes) & TestExpectations.suffixes_for_test_result(test_result)
class RebaselineJson(AbstractParallelRebaselineCommand):

Powered by Google App Engine
This is Rietveld 408576698